Fixing e2e vs integration test naming

[amitkrout]

What is the purpose of this change? What does it change?

Was the change discussed in an issue?

related to #1780

How to test changes?

Review the change properly

[kadel]

ping @amitkrout

[kadel]

why go test here but other commands use ginkgo ?

It would be nice to unify it all

[amitkrout]

Yup, will fix those.

[kadel]

wouldn't it be better to use make test-e2e-all to make sure that new e2e scenarios are executed once added?

[amitkrout]

+1

[kadel]

shouldn't this use test-e2e-all?

[amitkrout]

odo sub component command tests when component is in the current directory and --project flag is used 
  creates and pushes local nodejs component and then deletes --all
  /go/src/github.com/openshift/odo/tests/integration/component.go:329
 Created dir: /tmp/724815433
Creating a new project: texjxuxufc
Running odo with args [odo project create texjxuxufc -w -v4]
[odo] I0904 13:18:24.552396   19818 preference.go:118] The path for preference file is /tmp/724815433/config.yaml
[odo] I0904 13:18:24.552472   19818 occlient.go:479] Trying to connect to server api.ci-op-d1whffy3-f09f4.origin-ci-int-aws.dev.rhcloud.com:6443
[odo] I0904 13:18:24.567450   19818 occlient.go:486] Server https://api.ci-op-d1whffy3-f09f4.origin-ci-int-aws.dev.rhcloud.com:6443 is up
[odo] I0904 13:18:24.631580   19818 occlient.go:409] isLoggedIn err:  <nil> 
[odo]  output: "developer"
[odo]  •  Waiting for project to come up  ...
[odo]  ✓  Waiting for project to come up [353ms]
[odo]  ✓  Project 'texjxuxufc' is ready for use
[odo]  ✓  New project created and now using project : texjxuxufc
[odo] I0904 13:18:25.006691   19818 odo.go:70] Could not get the latest release information in time. Never mind, exiting gracefully :)
Current working dir: /go/src/github.com/openshift/odo/tests/integration
Setting current dir to: /tmp/724815433
Running odo with args [odo component create nodejs my-component --app app --project texjxuxufc --env key=value,key1=value1]
[odo]  •  Validating component  ...
[odo]  ✓  Validating component [37ms]
[odo] Please use `odo push` command to create the component with source deployed



[odo] 
Running odo with args [odo component push --context /tmp/724815433]
[odo]  ✗  invalid configuration: [context was not found for specified context: jgjryhzmbp/api-ci-op-d1whffy3-f09f4-origin-ci-int-aws-dev-rhcloud-com:6443/developer, cluster has no server defined]
[odo] Please login to your server: 
[odo] 
[odo] odo login https://mycluster.mydomain.com



[odo] 
Setting current dir to: /go/src/github.com/openshift/odo/tests/integration
Deleting project: texjxuxufc
Running odo with args [odo project delete texjxuxufc -f]
[odo]  •  Deleting project texjxuxufc  ...
[odo]  ✓  Deleting project texjxuxufc [5s]
[odo]  ✓  Deleted project : texjxuxufc
Deleting dir: /tmp/724815433
 • Failure [6.659 seconds]
odo sub component command tests
/go/src/github.com/openshift/odo/tests/integration/cmd_cmp_sub_test.go:13
  when component is in the current directory and --project flag is used
  /go/src/github.com/openshift/odo/tests/integration/component.go:306
    creates and pushes local nodejs component and then deletes --all [It]
    /go/src/github.com/openshift/odo/tests/integration/component.go:329
     No future change is possible.  Bailing out early after 0.102s.
      
    Running odo with args [odo component push --context /tmp/724815433]
    Expected
        <int>: 1
    to match exit code:
        <int>: 0
     /go/src/github.com/openshift/odo/tests/helper/helper_run.go:32

Could be a potential flake
/test integration
Issue created - #2088

[amitkrout]

/hold cancel

[kadel]

/lgtm

[kadel]

After this gets merged you should open PR against release repo to stop using the old scripts

• scripts/openshiftci-presubmit-e2e-scenarios.sh
• scripts/openshiftci-presubmit-e2e.sh