Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing e2e vs integration test naming #4939

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Fixing e2e vs integration test naming #4939

merged 1 commit into from
Sep 9, 2019

Conversation

amitkrout
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 5, 2019
@amitkrout
Copy link
Contributor Author

ping @kadel

@amitkrout
Copy link
Contributor Author

/test pj-rehearse

2 similar comments
@amitkrout
Copy link
Contributor Author

/test pj-rehearse

@amitkrout
Copy link
Contributor Author

/test pj-rehearse

@amitkrout
Copy link
Contributor Author

/refresh

@amitkrout
Copy link
Contributor Author

/test pj-rehearse

1 similar comment
@amitkrout
Copy link
Contributor Author

/test pj-rehearse

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2019
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2019
@mohammedzee1000
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout, mohammedzee1000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1bab031 into openshift:master Sep 9, 2019
@openshift-ci-robot
Copy link
Contributor

@amitkrout: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-odo-master.yaml using file ci-operator/config/openshift/odo/openshift-odo-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-odo-master.yaml using file ci-operator/config/openshift/odo/openshift-odo-master.yaml
  • job-config-master-presubmits configmap in namespace ci using the following files:
    • key openshift-odo-master-presubmits.yaml using file ci-operator/jobs/openshift/odo/openshift-odo-master-presubmits.yaml

In response to this:

redhat-developer/odo#1878 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@amitkrout: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/odo/master/unit fd1b8d3381233150ba453fdf849ea43da98d7a87 link /test pj-rehearse
ci/rehearse/openshift/odo/master/integration 3afdd93 link /test pj-rehearse
ci/prow/pj-rehearse 3afdd93 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This was referenced Sep 9, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage Awaiting requested review from cdrage

@kadel kadel Awaiting requested review from kadel

Assignees

@mohammedzee1000 mohammedzee1000

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amitkrout @mohammedzee1000 @openshift-ci-robot @openshift-merge-robot