Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump odo version to 1.0.0-beta6 #2182

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Bump odo version to 1.0.0-beta6 #2182

merged 1 commit into from
Sep 26, 2019

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Sep 25, 2019

Enhancements

Bug Fixes

Testing

Documentation

@dharmit
Copy link
Member Author

dharmit commented Sep 25, 2019

Need to merge #2177 first.

@kadel
Copy link
Member

kadel commented Sep 25, 2019

✗ Failed To Update Config To Component Deployed
#1981
/retest

@amitkrout
Copy link
Contributor

/approve
ping @girishramnani

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 26, 2019
@dharmit
Copy link
Member Author

dharmit commented Sep 26, 2019

Should I not be adding Enhancements, Fixes, etc. so that they show up on release page? Give me some time and I'll update the description of the PR with those details.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Sep 26, 2019
@dharmit
Copy link
Member Author

dharmit commented Sep 26, 2019

/hold cancel

ping @girishramnani @kadel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Sep 26, 2019
@girishramnani
Copy link
Contributor

A bit more description per point?

@dharmit
Copy link
Member Author

dharmit commented Sep 26, 2019

A bit more description per point?

Are you asking me to write an essay in Changelog? 🙄

UPDATE: Can you PTAL at the updated description?

@cdrage
Copy link
Member

cdrage commented Sep 26, 2019

I think that writing it in vim may have messed up the spacing, but when you do the release, turn:

Add json output for odo catalog list services (#2066)
This helps the consumers of odo, i.e., Adapters

To:

Add json output for odo catalog list services. This helps the consumers of odo, i.e., Adapters (#2066)

Similar to the previous format, have it so that it's 1 sentence and that the link to the PR is at the end.

@dharmit
Copy link
Member Author

dharmit commented Sep 26, 2019

I think that writing it in vim may have messed up the spacing, but when you do the release, turn:

Add json output for odo catalog list services (#2066)
This helps the consumers of odo, i.e., Adapters

To:

Add json output for odo catalog list services. This helps the consumers of odo, i.e., Adapters (#2066)

Similar to the previous format, have it so that it's 1 sentence and that the link to the PR is at the end.

No, it wasn't vim. I edited the description on GH. But yeah I felt like it was a bit out of place. I'll modify that.

@@ -398,6 +406,28 @@ By default, builder images will be used from the current namespace. You can expl

A full list of component types that can be deployed is available using: 'odo catalog list'

[[debug]]
debug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is debug section empty?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I'm not sure if that's something I should have added or make generate-cli-reference should have.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, no examples in the command-line. It will have to be fixed there.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 26, 2019
@kadel
Copy link
Member

kadel commented Sep 26, 2019

/retest

error: error pulling image registry.svc.ci.openshift.org/ci/clonerefs@sha256:99ef47c07da4a436f069583cb2326e9e8c2b0f296400eee48e865872a17a33eb: Get https://registry.svc.ci.openshift.org/v2/ci/clonerefs/manifests/sha256:99ef47c07da4a436f069583cb2326e9e8c2b0f296400eee48e865872a17a33eb: net/http: TLS handshake timeout

@openshift-merge-robot openshift-merge-robot merged commit 0cdcc90 into redhat-developer:master Sep 26, 2019
@rm3l rm3l added the estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants