-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump odo version to 1.0.0-beta6 #2182
Conversation
Need to merge #2177 first. |
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amitkrout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Should I not be adding Enhancements, Fixes, etc. so that they show up on release page? Give me some time and I'll update the description of the PR with those details. /hold |
/hold cancel ping @girishramnani @kadel |
A bit more description per point? |
Are you asking me to write an essay in Changelog? 🙄 UPDATE: Can you PTAL at the updated description? |
I think that writing it in vim may have messed up the spacing, but when you do the release, turn: Add json output for odo catalog list services (#2066)
This helps the consumers of odo, i.e., Adapters To: Add json output for odo catalog list services. This helps the consumers of odo, i.e., Adapters (#2066) Similar to the previous format, have it so that it's 1 sentence and that the link to the PR is at the end. |
No, it wasn't vim. I edited the description on GH. But yeah I felt like it was a bit out of place. I'll modify that. |
@@ -398,6 +406,28 @@ By default, builder images will be used from the current namespace. You can expl | |||
|
|||
A full list of component types that can be deployed is available using: 'odo catalog list' | |||
|
|||
[[debug]] | |||
debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is debug section empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, I'm not sure if that's something I should have added or make generate-cli-reference
should have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, no examples in the command-line. It will have to be fixed there.
/lgtm
/retest
|
Enhancements
odo debug
.odo
now lets users debug the application running in the pod on OpenShift (odo experimental debug port-forward command #2043)odo catalog list services
. This helps the consumers ofodo
, i.e., Adapters (Addsodo catalog list services -o json
#2066)odo service list
. This helps the consumers ofodo
, i.e., Adapters (Addsodo service list -o json
#2098)odo
will be available andodo
could be installed withyum/dnf install odo
(Setting up rpm spec for odo for rpm build #2107)Bug Fixes
odo service create
didn't pick-up the values provided for parameters with-p
flag (add parameter map population in non-interactive service creation #2040)odo list
for component that's not pushed.odo list
output was empty for the components that have not been pushed (Fixes list output in odo directory when component is not pushed #2046)Testing
This makes debugging less painful to the eyes.
Documentation