Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes overlapping messages for odo git components #2091

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Removes overlapping messages for odo git components #2091

merged 1 commit into from
Sep 10, 2019

Conversation

mik-dass
Copy link
Contributor

@mik-dass mik-dass commented Sep 5, 2019

fixes #1971

How to test:

  1. Create a git component and push twice
  2. Try all update scenarios e.g git to local

No overlapping should happen in the logs

dharmit
dharmit approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 9, 2019
cdrage
cdrage suggested changes Sep 9, 2019
View reviewed changes
pkg/component/component.go

s.End(true)

// Trigger build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why we are moving the below code into this section rather than keeping it withinCreateWithGit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to #1971 (comment), build and deploy should happen outside the CreateFromGit function, so I removed it from there

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks.

cdrage
cdrage approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 10, 2019
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit aa1050b into redhat-developer:master Sep 10, 2019
@mik-dass mik-dass deleted the git_overlap branch September 11, 2019 04:52
@dharmit dharmit mentioned this pull request Sep 26, 2019
Merged
@rm3l rm3l added the estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharmit dharmit dharmit approved these changes

@cdrage cdrage cdrage approved these changes

@girishramnani girishramnani Awaiting requested review from girishramnani

Assignees

@cdrage cdrage

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overlapping messages when pushing git component
7 participants
@mik-dass @openshift-ci-robot @openshift-bot @dharmit @cdrage @rm3l @openshift-merge-robot