Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup test naming - e2e vs integration #1780

Closed
kadel opened this issue May 30, 2019 · 12 comments
Closed

Cleanup test naming - e2e vs integration #1780

kadel opened this issue May 30, 2019 · 12 comments
Assignees
Labels
area/refactoring Issues or PRs related to code refactoring area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person kind/bug Categorizes issue or PR as related to a bug. priority/Medium Nice to have issue. Getting it done before priority changes would be great.

Comments

@kadel
Copy link
Member

kadel commented May 30, 2019

There is still a lot of places (like Makefile, or names of Describe blocks) where integration tests are named as e2e or have e2e in the name.
This should be cleaned to make it clear that those are two different tests approaches.

/kind bug
/area testing
/priority medium
/project Sprint 168

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering priority/Medium Nice to have issue. Getting it done before priority changes would be great. labels May 30, 2019
@kadel
Copy link
Member Author

kadel commented May 30, 2019

/project "Sprint 168"

@dharmit
Copy link
Member

dharmit commented Jun 11, 2019

Issue description is really clear in this case! For example: https://github.com/openshift/odo/blob/009f9d7e775caef0dc63d2a361f2eeb423398a05/Makefile#L106-L109

has the name test-cmp-e2e but lives under tests/integration directory. There are many such tests with e2e in their name but living under test/integration dir.

@dharmit
Copy link
Member

dharmit commented Jun 11, 2019

/label state/Ready
/remove-label "state/In Analysis"

1 similar comment
@kadel
Copy link
Member Author

kadel commented Jun 11, 2019

/label state/Ready
/remove-label "state/In Analysis"

@dharmit
Copy link
Member

dharmit commented Jun 11, 2019

The bot's on a PTO, maybe? 🤔

@kadel
Copy link
Member Author

kadel commented Jun 19, 2019

This should be also updated in https://github.com/openshift/release

@amitkrout
Copy link
Contributor

This should be also updated in https://github.com/openshift/release

Right, I will fix all those reference of e2e related to test.

@amitkrout
Copy link
Contributor

Pr sent openshift/release#4268 for OpenShift CI job and config changes

@girishramnani girishramnani added estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person and removed points/3 labels Jul 24, 2019
@kadel
Copy link
Member Author

kadel commented Aug 22, 2019

Is there a PR for this on odo side?

@girishramnani
Copy link
Contributor

PR for this issue #1878

@kadel
Copy link
Member Author

kadel commented Sep 19, 2019

/close
#1878

@openshift-ci-robot
Copy link
Collaborator

@kadel: Closing this issue.

In response to this:

/close
#1878

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/refactoring Issues or PRs related to code refactoring area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person kind/bug Categorizes issue or PR as related to a bug. priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
Archived in project
Development

No branches or pull requests

6 participants