Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CUDA 12.2 wheels #7

Closed
4 tasks done
Tracked by #6
vyasr opened this issue Dec 15, 2023 · 11 comments
Closed
4 tasks done
Tracked by #6

Add support for CUDA 12.2 wheels #7

vyasr opened this issue Dec 15, 2023 · 11 comments
Assignees
@jameslamb

Comments

@vyasr
Copy link
Contributor

vyasr commented Dec 15, 2023 •
edited by jameslamb
Loading

We would like to start publishing wheels that support versions of CUDA newer than CUDA 12.0. Currently, this requires that we:

Once we have 12.2 wheels and conda packaging has caught up, we may wish to revisit the CTK version and go to 12.3. For initial work we will start with 12.2, though.
This was referenced Dec 15, 2023
Closed
Closed
This was referenced Dec 18, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@jameslamb
Copy link
Member

Update the ci-imgs repo to build images with the desired CUDA versions

I believe this is done as of rapidsai/miniforge-cuda#56 and rapidsai/ci-imgs#101.

This was referenced Jan 4, 2024
Merged
Merged
Merged
Merged
Merged
@jameslamb
Copy link
Member

jameslamb commented Jan 10, 2024 •
edited
Loading

Based on my conversations with @bdice over the last few days, we're going to try rolling out dependencies.yaml changes similar to rapidsai/rmm#1422 across all RAPIDS repos as a part of this.

Tracking that here.

This was referenced Jan 10, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
rapids-bot bot pushed a commit to rapidsai/ucx-py that referenced this issue Jan 10, 2024
@jameslamb
refactor CUDA versions in dependencies.yaml (#1014)
9231fef 
Contributes to rapidsai/build-planning#7.

Proposes splitting the `cuda-version` dependency in `dependencies.yaml` out to its own thing, separate from the bits of the CUDA Toolkit this project needs.

### Benefits of this change

* prevents accidental inclusion of multiple `cuda-version` version in environments
* reduces update effort (via enabling more use of globs like `"12.*"`)
* improves the chance that errors like "`conda` recipe is missing a dependency" are caught in CI

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #1014
This was referenced Jan 10, 2024
Merged
Merged
This was referenced Feb 15, 2024
Merged
Merged
Merged
@jameslamb
Copy link
Member

jameslamb commented Feb 15, 2024 •
edited
Loading

Next steps is changing all those GitHub Actions configs from {workflow}.yaml@test-cuda-12.2 to {workflow}.yaml@branch-24.04.

Put up PRs for those:

rapids-bot bot pushed a commit to rapidsai/ucxx that referenced this issue Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#191)
e011f42 
Follow-up to #161

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Ray Douglass (https://github.com/raydouglass)

URL: #191
rapids-bot bot pushed a commit to rapidsai/ucx-py that referenced this issue Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#1026)
1b620ae 
Follow-up to #1015

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #1026
rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this issue Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#1314)
193d72f 
Follow-up to #1302

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #1314
@jameslamb jameslamb mentioned this issue Feb 20, 2024
Merged
6 tasks
rapids-bot bot pushed a commit to rapidsai/rmm that referenced this issue Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#1468)
76bd29d 
Follow-up to #1419

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #1468
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this issue Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#15069)
ef63596 
Follow-up to #14712

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #15069
rapids-bot bot pushed a commit to rapidsai/kvikio that referenced this issue Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#343)
e871389 
Follow-up to #328

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #343
rapids-bot bot pushed a commit to rapidsai/cucim that referenced this issue Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#702)
e5d1eaf 
Follow-up to #672

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #702
rapids-bot bot pushed a commit to rapidsai/raft that referenced this issue Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#2189)
573a034 
Follow-up to #2092

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)
  - https://github.com/jakirkham

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #2189
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this issue Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#4175)
f78f8d0 
Follow-up to #4088

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)
  - https://github.com/jakirkham

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #4175
rapids-bot bot pushed a commit to rapidsai/wholegraph that referenced this issue Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#135)
41728c7 
Follow-up to #116

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #135
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this issue Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#1343)
14ef631 
Follow-up to #1320

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #1343
rapids-bot bot pushed a commit to rapidsai/cuxfilter that referenced this issue Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#571)
af62e4a 
Follow-up to #563

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #571
rapids-bot bot pushed a commit to rapidsai/rapids-cmake that referenced this issue Feb 20, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#541)
7a3a1cd 
Follow-up to #521

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #541
This was referenced Feb 20, 2024
Closed
Closed
Merged
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this issue Feb 21, 2024
@jameslamb
target branch-24.04 for GitHub Actions workflows (#5776)
f16a8a9 
Follow-up to #5711

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #5776
@jameslamb
Copy link
Member

jameslamb commented Feb 21, 2024 •
edited by bdice
Loading

Last few activities we've identified to finish this work:

@jameslamb jameslamb mentioned this issue Feb 21, 2024
Merged
rapids-bot bot pushed a commit to rapidsai/docker that referenced this issue Feb 26, 2024
@jakirkham
Add CUDA 12.2 (#634)
32a60e1 
Add CUDA 12.2 images to the build matrix

References:

* rapidsai/build-planning#6
* rapidsai/build-planning#7
* rapidsai/build-planning#8

Authors:
  - https://github.com/jakirkham
  - Ray Douglass (https://github.com/raydouglass)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Ray Douglass (https://github.com/raydouglass)

URL: #634
@bdice
Copy link
Contributor

bdice commented Feb 27, 2024

I'm going to mark this issue as complete, now that we're down to just one task (which we are going to wait before merging). rapidsai/ci-imgs#116 (comment)

We should use #6 for any further discussions, now that this issue (focused on wheels) is complete.

@bdice bdice closed this as completed Feb 27, 2024
younseojava pushed a commit to ROCm/dask-cuda-rocm that referenced this issue Apr 16, 2024
@jameslamb @younseojava
refactor CUDA versions in dependencies.yaml (rapidsai#1303)
e715119 
Contributes to rapidsai/build-planning#7.

Proposes splitting the `cuda-version` dependency in `dependencies.yaml` out to its own thing, separate from the bits of the CUDA Toolkit this project needs.

### Benefits of this change

* prevents accidental inclusion of multiple `cuda-version` version in environments
* reduces update effort (via enabling more use of globs like `"12.*"`)
* improves the chance that errors like "`conda` recipe is missing a dependency" are caught in CI

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#1303
younseojava pushed a commit to ROCm/dask-cuda-rocm that referenced this issue Apr 16, 2024
@jameslamb @younseojava
Support CUDA 12.2 (rapidsai#1302)
1e315a2 
* switches to CUDA 12.2.2 for building conda packages and wheels
* adds new tests running against CUDA 12.2.2

This is part of ongoing work to build and test wheels against CUDA 12.2.2 across all of RAPIDS. For more details see:

* rapidsai/build-planning#7
* rapidsai/shared-workflows#166

### Notes for Reviewers

Planning a second round of PRs to revert these references back to a proper `branch-24.{nn}` release branch of `shared-workflows` once rapidsai/shared-workflows#166 is merged.

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#1302
younseojava pushed a commit to ROCm/dask-cuda-rocm that referenced this issue Apr 16, 2024
@jameslamb @younseojava
target branch-24.04 for GitHub Actions workflows (rapidsai#1314)
fec96f3 
Follow-up to rapidsai#1302

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#1314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jameslamb jameslamb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vyasr @bdice @jameslamb