-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CUDA 12.2 #5711
Support CUDA 12.2 #5711
Conversation
01c9e42
to
d22e445
Compare
The new CUDA 12.2 builds are failing with 2 issues. conda packages
That should be fixed by rapidsai/rapids-cmake#522. wheels
That looks similar to something |
Looks like this needs PR ( rapidsai/gputreeshap#42 ) |
Testing this in PR ( #5719 ) |
It looks like CUDA 12.2 passes! 🎉 There is a CUDA 11.8 failure with Dask though. After a cursory look, am not seeing any obvious cause test_sparse_from_dense[8-float32-regularization0-True]
...
E assert <array_equal: [ 0.64805114 0.40563476 -0.03294854 ... -0.20645222 -0.2884561 -0.13163252] [ 0.64738656 0.40191636 -0.03218034 ... -0.20163251 -0.28334481 -0.12986547] unit_tol=0.005 total_tol=0.0001 with_sign=True>
E + where <array_equal: [ 0.64805114 0.40563476 -0.03294854 ... -0.20645222 -0.2884561 -0.13163252] [ 0.64738656 0.40191636 -0.03218034 ... -0.20163251 -0.28334481 -0.12986547] unit_tol=0.005 total_tol=0.0001 with_sign=True> = array_equal(array([ 0.64805114, 0.40563476, -0.03294854, 0.05359353, -0.44779027,\n -0.20645222, -0.2884561 , -0.13163252], dtype=float32), array([ 0.64738656, 0.40191636, -0.03218034, 0.05311682, -0.45539661,\n -0.20163251, -0.28334481, -0.12986547]), 0.005, with_sign=True)
test_dask_logistic_regression.py:393: AssertionError |
Looks like @dantegd re-triggered that build and now the test passed: https://github.com/rapidsai/cuml/actions/runs/7642195211/job/20839681496?pr=5711 So maybe it is a flaky test? Either way, seems that it should be unrelated to CUDA 12.2 support since it's happening on the 11.8 job. |
Restarting CI now that the pandas 2 fixes are merged in #5758. We can check out the logs tomorrow. |
Ready for ops review - CI looks good. Triggering |
/merge |
Follow-up to #5711 For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows` with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged. ### Notes for Reviewers This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS. For more details see: * rapidsai/build-planning#7 *(created with `rapids-reviser`)* Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #5776
Description
"12.*"
globs independencis.yaml
missed in refactor CUDA versions in dependencies.yaml #5712Closes #5765
Notes for Reviewers
This is part of ongoing work to build and test wheels against CUDA 12.2.2 across all of RAPIDS. For more details see:
(created with rapids-reviser)