Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor CUDA versions in dependencies.yaml #5712

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Jan 10, 2024

Description

Contributes to rapidsai/build-planning#7.

Proposes splitting the cuda-version dependency in dependencies.yaml out to its own thing, separate from the bits of the CUDA Toolkit this project needs.

Benefits of this change

  • prevents accidental inclusion of multiple cuda-version version in environments
  • reduces update effort (via enabling more use of globs like "12.*")
  • improves the chance that errors like "conda recipe is missing a dependency" are caught in CI

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 11, 2024
@bdice
Copy link
Contributor

bdice commented Jan 11, 2024

/merge

@rapids-bot rapids-bot bot merged commit d9fdf50 into rapidsai:branch-24.02 Jan 11, 2024
54 checks passed
@jameslamb jameslamb mentioned this pull request Jan 11, 2024
@jameslamb jameslamb deleted the rework-dependencies branch January 11, 2024 19:02
rapids-bot bot pushed a commit that referenced this pull request Feb 12, 2024
* switches to CUDA 12.2.2 for building wheels
* adds new tests running against CUDA 12.2.2
* adds some `"12.*"` globs in `dependencis.yaml` missed in #5712

Closes #5765 

### Notes for Reviewers

This is part of ongoing work to build and test wheels against CUDA 12.2.2 across all of RAPIDS. For more details see:

* rapidsai/build-planning#7
* rapidsai/shared-workflows#166

*(created with [rapids-reviser](https://github.com/rapidsai/rapids-reviser))*

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #5711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants