This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
refactor CUDA versions in dependencies.yaml #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
bdice
reviewed
Jan 11, 2024
dependencies.yaml
Outdated
| @@ -137,9 +162,8 @@ dependencies: | |||
| - cudatoolkit=11.8 | |||
There was a problem hiding this comment.
Please drop the cudatoolkit version pinnings from this section. Edit all the lines like cudatoolkit=11.8 so it's just cudatoolkit, which will be constrained by cuda-version=11.8.
bdice
approved these changes
Jan 11, 2024
|
/merge |
raydouglass
added
improvement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#7.
Proposes splitting the
cuda-versiondependency independencies.yamlout to its own thing, separate from the bits of the CUDA Toolkit this project needs.Benefits of this change
cuda-versionversion in environments"12.*")condarecipe is missing a dependency" are caught in CINotes for Reviewers
This change was intended to just re-organize
dependencies.yaml, but I do think the one additional change it introduces toall_cuda-118_arch-x86_64.yamlis a good one. I think requiring thecuda-versionmetapackage in all environments is useful to prevent against environment solves that result in runtime issues.References: