Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make release v23.9 #3538

Merged
merged 1,102 commits into from
Nov 20, 2023
Merged

Make release v23.9 #3538

merged 1,102 commits into from
Nov 20, 2023

Conversation

Saransh-cpp
Copy link
Member

Description

I will create a release once this is merged into main.

Fixes #3374

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Saransh-cpp and others added 30 commits August 23, 2023 19:06
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
Split CI test groups into concurrent jobs
Invoke custom `build.jobs` for PDF builds on Read the Docs
kratman and others added 18 commits October 3, 2023 16:20
* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Bug fix: Improve cracking integration tests and examples on M-series hardware
…-support

Drop support for i686 manylinux
Improve release workflow, add a note, bump version manually
Build wheels on the 1st and 15th of every month
make initial soc work with half cell models
JaxSolver fails when using GPU support with no input parameters
Resolve default imports for optional dependencies
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! Are the mac failing tests new?

@Saransh-cpp
Copy link
Member Author

Yes, looks like a new error. I will try rerunning them once the other tests are executed.

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (9efd58b) 99.71% compared to head (e00b0d5) 99.58%.
Report is 5 commits behind head on main.

Files Patch % Lines
pybamm/models/submodels/particle/msmr_diffusion.py 93.24% 16 Missing ⚠️
pybamm/solvers/jax_solver.py 79.31% 6 Missing ⚠️
...s/full_battery_models/lithium_ion/electrode_soh.py 97.69% 5 Missing ⚠️
...amm/models/full_battery_models/lithium_ion/msmr.py 72.22% 5 Missing ⚠️
...odels/interface/open_circuit_potential/msmr_ocp.py 88.88% 3 Missing ⚠️
...m/models/full_battery_models/base_battery_model.py 96.87% 2 Missing ⚠️
...submodels/interface/kinetics/msmr_butler_volmer.py 96.49% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3538      +/-   ##
==========================================
- Coverage   99.71%   99.58%   -0.13%     
==========================================
  Files         248      256       +8     
  Lines       18900    20106    +1206     
==========================================
+ Hits        18846    20023    +1177     
- Misses         54       83      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saransh-cpp
Copy link
Member Author

Looks like this has been fixed in develop, but not in v23.9. The scheduled macos tests are passing on this PR so it should be fine to merge this.

Leaving this open for reviews. Will merge this in an hour!

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks, @Saransh-cpp! The macOS tests are failing because of the brew update command, which has been fixed in the develop branch as you mentioned.

@Saransh-cpp Saransh-cpp merged commit 97ca773 into main Nov 20, 2023
40 of 53 checks passed
@Saransh-cpp Saransh-cpp deleted the v23.9 branch November 20, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.