Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize PyBaMM #3223

Merged
merged 47 commits into from
Aug 29, 2023
Merged

Dockerize PyBaMM #3223

merged 47 commits into from
Aug 29, 2023

Conversation

arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Aug 2, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #1926

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (e7bd82f) 99.71% compared to head (c0d7abf) 99.70%.
Report is 47 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3223      +/-   ##
===========================================
- Coverage    99.71%   99.70%   -0.01%     
===========================================
  Files          248      248              
  Lines        18871    18890      +19     
===========================================
+ Hits         18817    18835      +18     
- Misses          54       55       +1     

see 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saransh-cpp Saransh-cpp self-requested a review August 4, 2023 15:05
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks, @arjxn-py!! We would need some docs for this, maybe a new "Install using Docker" page with the contents discussed in the meeting.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
arjxn-py and others added 3 commits August 7, 2023 19:30
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
@agriyakhetarpal
Copy link
Member

agriyakhetarpal commented Aug 7, 2023

gabrieldemarmiesse/python-on-whales looks like a nice project that we can end up using for a Python CLI script wrapper over this Dockerfile, titled docker_install.py. We could also add another interface to it through a pybamm_install_docker entry point in the console_scripts group in setup.py. I would be glad to help around with this

Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@arjxn-py
Copy link
Member Author

pre-commit.ci run

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thanks @arjxn-py 🥳

One final comment -

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @arjxn-py! :)

Some documentation suggestions -

Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerize PyBaMM?
4 participants