Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update release workflow link #3403

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Oct 3, 2023

Description

Minor update to the release workflow link.

Fixes #3384

Type of change

No breaking change here, just documentation.

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kratman

@brosaplanella brosaplanella merged commit df95a07 into pybamm-team:develop Oct 3, 2023
31 of 33 checks passed
@brosaplanella
Copy link
Sponsor Member

@all-contributors please add @arjxn-py for PR review

@allcontributors
Copy link
Contributor

@brosaplanella

I've put up a pull request to add @arjxn-py! 🎉

@kratman kratman deleted the bug/fixReleaseLink branch October 3, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix release workflow link in issue template
4 participants