(BUGFIX) Update to ensure correct facter comparisons #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david22swan
force-pushed
the
bugfix/facter_case_fix
branch
from
435d4cd to
bacd9ee
Compare
ekohl
previously approved these changes
Feb 9, 2023
david22swan
force-pushed
the
bugfix/facter_case_fix
branch
from
bacd9ee to
7dfac44
Compare
Ensuring that the correct values are compared against facter, there seem to be many cases where lowercase has been used in place of uppercase.
david22swan
force-pushed
the
bugfix/facter_case_fix
branch
from
7dfac44 to
290e096
Compare
pmcmaw
approved these changes
Feb 10, 2023
|
Out of interest: how did you find this? I'm personally in the camp of "there should be one way and one way only", which implies always using the same casing so big 👍 to this. I just wonder, did you ran into this because of some bug/tooling issue? |
|
@ekohl Sorry for the late reply, came up in regards to the fix for the templates in my other PR: https://github.com/puppetlabs/puppetlabs-apache/pull/2381/files |
|
Oh yes, ERB is Ruby so case sensitive comparisons. I dislike that Puppet does case insensitive comparisons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensuring that the correct values are compared against facter, there seem to be many cases where lowercase has been used in place of uppercase.