Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update $timeout to Variant[Integer,String] #2242

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Update $timeout to Variant[Integer,String] #2242

merged 1 commit into from
Jun 9, 2022

Conversation

david22swan
Copy link
Member

No description provided.

@puppet-community-rangefinder
Copy link

apache is a class

Breaking changes to this file WILL impact these 144 modules (exact match):
Breaking changes to this file MAY impact these 55 modules (near match):

This module is declared in 174 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

david22swan referenced this pull request Jun 9, 2022
@david22swan
(GH-cat-9) Update code to match syntax standard, part 2
ae56cc9 
Code now compliant with the following rules:
- parameter_documentation
- parameter_types
@ekohl
Copy link
Collaborator

ekohl commented Jun 9, 2022

This looks very similar to #2241

@david22swan david22swan marked this pull request as ready for review June 9, 2022 09:48
@david22swan david22swan requested a review from a team as a code owner June 9, 2022 09:48
@LukasAud LukasAud merged commit dd36951 into main Jun 9, 2022
@LukasAud LukasAud deleted the david22swan-patch-1 branch June 9, 2022 09:50
@ekohl
Copy link
Collaborator

ekohl commented Jun 9, 2022

@LukasAud I really would have expected you to at least look at #2241 and comment on it. It takes a stricter approach and given the next version will be a major, I think it's a better implementation of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasAud LukasAud LukasAud approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david22swan @ekohl @LukasAud