Eye icon added infront of followers name #7522

NitinBhasneria · 2020-02-17T14:31:19Z

Fixes #6304 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

codecov · 2020-02-17T14:40:04Z

Codecov Report

Merging #7522 into main will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7522   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files          97       97           
  Lines        5627     5627           
=======================================
  Hits         4611     4611           
  Misses       1016     1016

NitinBhasneria · 2020-02-17T14:45:56Z

@cesswairimu Can you review this pr?

VladimirMikulic · 2020-02-17T18:36:52Z

Could you please post a screenshot of your change? Every time you do a UI change, you are required to provide a screenshot show casing the change.

NitinBhasneria · 2020-02-17T18:55:53Z

As it is a feature the UI change is not shown in screen as for server there are no followers!! @VladimirMikulic

nstjean · 2020-02-17T19:00:06Z

So what you will need to do is add some data to your local server so that you can test out the feature. When you open the website at localhost you can log in as user (password:password) and then follow a bunch of topics. Then as admin you can log in to see if it is showing up properly.

NitinBhasneria · 2020-02-18T13:24:24Z

this is how it will look. @VladimirMikulic @nstjean @cesswairimu

cesswairimu · 2020-02-19T04:34:22Z

Hi @NitinBhasneria , this is looking good... I think we can have the >> on the same line as the Notes I think that would look more arranged What do you think?. Also, would like to do the second part of the issue on this PR or should I open another issue for it. Thanks for working on this.

cesswairimu · 2020-02-19T04:35:03Z

Another thing, did you remove the other column? please add a screenshot of the whole page. Thanks

NitinBhasneria · 2020-02-19T08:11:24Z

Hi @NitinBhasneria , this is looking good... I think we can have the >> on the same line as the Notes I think that would look more arranged What do you think?. Also, would like to do the second part of the issue on this PR or should I open another issue for it. Thanks for working on this.

Thanks, @cesswairimu I will arrange that Notes thing in this pr also for the second part please open another issue and close the previous one

NitinBhasneria · 2020-02-19T08:13:19Z

Another thing, did you remove the other column? please add a screenshot of the whole page. Thanks

Ahh @cesswairimu I am little confused, do we have to remove the follower's column?

NitinBhasneria · 2020-02-19T16:04:09Z

Notes arranged

cesswairimu · 2020-02-19T19:02:06Z

Great, the arrangement looks great...No, but we need to just show the followers who are following and are not part of the contributors..how that we have the eye icon showing the contributors who are subscribed..makes sense?

NitinBhasneria · 2020-02-19T19:14:11Z

Yea it does make sense in a way we don't have to check in the follower's list and match if the contributor is also following or not!! @cesswairimu
As, according to the issue, we should show if the contributor if following or not!

cesswairimu · 2020-02-19T19:57:26Z

Great...and Jeff suggestion was to rename that column to Following

NitinBhasneria · 2020-02-19T19:59:54Z

So should we make another column named following to show the eye icon?

cesswairimu · 2020-02-19T20:02:59Z

Mmmh I think we should rename the one with people who are followers to following and just leave the other one with just the eye icon.....or will it cause confusing?

NitinBhasneria · 2020-02-19T20:12:40Z

Actually, an eye icon without any heading or column can make it confusing.
So, what I think is making the following column in table one which will have eye icons for the contributors who are following.
and renaming the column named people who are following to following in table two.

cesswairimu · 2020-02-19T20:14:51Z

sounds good. Thanks 👍

NitinBhasneria · 2020-02-19T20:16:27Z

So, should I work on this in this pr?
@cesswairimu

cesswairimu · 2020-02-19T20:18:53Z

yeah id you are up for it...or we could sseparate it in another issue.totally your choice

NitinBhasneria · 2020-02-19T20:21:25Z

Yea, we should separate it in another issue.
This will be a less mess then.
Thanks @cesswairimu

cesswairimu · 2020-02-19T20:24:16Z

okay cool...then lets add column of the eye icon and I will create another issue of having the followers exclude the contributors. Thanks

NitinBhasneria · 2020-02-19T20:46:47Z

@cesswairimu This pr work is done and this is how it will look

but the followers table has shifted to down instead of right, so this also need to be fixed in another issue.
Thanks

plotsbot · 2020-02-19T20:57:20Z

	1 Warning
⚠️	There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml

	2 Messages
📖	@NitinBhasneria Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	#

Screenshots 📸 (click to expand)

7522-test_questions.png

7522-test_embeddable_grids.png

7522-test_signup.png

7522-test_viewing_the_settings_page.png

7522-test_tag_by_author_page.png

7522-test_wiki_page_with_inline_grids.png

7522-test_stats.png

7522-test_viewing_the_dashboard.png

7522-test_searching_an_item_from_the_homepage.png

7522-test_signup_modal_form_validation.png

7522-test_tag_stats.png

7522-test_login_modal_form_validation.png

7522-test_questions_shadow.png

7522-test_login_modal.png

7522-test_profile_page.png

7522-test_comments.png

7522-test_tags.png

7522-test_signup_modal.png

7522-test_wiki.png

7522-test_methods.png

7522-test_tag_page.png

7522-test_blog_page_with_location_modal.png

7522-test_tag_wildcard.png

7522-test_signup_modal_disabled_submit_button_on_empty_username.png

7522-test_embeddable_thumbnail_grids.png

7522-test_front_page_with_navbar_search_autocomplete.png

7522-failures_test_following_the_wiki_author.png

7522-test_spam_moderation_page.png

7522-test_login.png

7522-test_viewing_the_dropdown_menu.png

7522-test_viewing_question_post.png

7522-test_mobile_displays.png

7522-test_simple-data-grapher_powertag.png

7522-test_front.png

7522-test_question_page.png

7522-test_tag_contributors_page.png

7522-test_blog.png

7522-test_people.png

7522-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

NitinBhasneria · 2020-03-01T07:18:53Z

@nstjean @cesswairimu I am getting this error in travis. Any idea?

cesswairimu · 2020-03-02T16:57:43Z

Not sure why it is happening...Is it failing locally?

NitinBhasneria · 2020-03-02T18:15:47Z

Not sure why it is happening...Is it failing locally?
@cesswairimu
Same travis error in pr #7445

VladimirMikulic · 2020-03-02T19:14:20Z

@cesswairimu all tests pass locally, but some of them like this one fail in production for some reason.

cesswairimu · 2020-03-03T18:17:27Z

I will restart travis one more time...Travis passed on the other PR

NitinBhasneria · 2020-03-09T13:12:54Z

@cesswairimu You can review it now as all checks have been passed also we can continue this.

cesswairimu · 2020-03-15T19:24:18Z

I will push up the alignment of the components so that we can merge it together. Thanks

NitinBhasneria · 2020-04-05T18:38:02Z

@cesswairimu Please merge this. Thanks

cesswairimu

@NitinBhasneria I found a PR that fixed the alignment issue here #7331 you can see the new changes here https://stable.publiclab.org/contributors/soc please rebase and paste the final screenshot here. Thanks

cesswairimu · 2020-09-18T19:39:55Z

@NitinBhasneria could we please get a screenshot for this so that we can merge? also kindly rebase. Thanks

cesswairimu · 2020-10-29T16:49:38Z

This PR has been open for a long time and no activity/ reviews requested has not been addressed. We understand you might be busy and engaged on other things. I am closing this for now...please feel free to reopen if you get some time and would like to finish this. Rem to check if its still available before you reopen. Thanks

Eye icon added infromt of followers name

4072c46

NitinBhasneria requested review from IshaGupta18 and jywarren February 17, 2020 14:31

NitinBhasneria changed the title ~~Eye icon added infromt of followers name~~ Eye icon added infront of followers name Feb 17, 2020

NitinBhasneria requested review from nstjean and VladimirMikulic February 17, 2020 18:04

VladimirMikulic approved these changes Feb 18, 2020

View reviewed changes

Notes >> arranged

b3ba5f1

Coloum named following added for eye icon

78517d3

NitinBhasneria closed this Mar 1, 2020

NitinBhasneria reopened this Mar 1, 2020

Merge branch 'master' into nitin-feature1

d321735

cesswairimu requested changes Apr 13, 2020

View reviewed changes

jywarren changed the base branch from master to main June 30, 2020 18:06

cesswairimu closed this Sep 18, 2020

cesswairimu reopened this Sep 18, 2020

cesswairimu closed this Oct 29, 2020

Eye icon added infront of followers name #7522

Eye icon added infront of followers name #7522

Conversation

NitinBhasneria commented Feb 17, 2020

codecov bot commented Feb 17, 2020 • edited Loading

Codecov Report

NitinBhasneria commented Feb 17, 2020

VladimirMikulic commented Feb 17, 2020

NitinBhasneria commented Feb 17, 2020

nstjean commented Feb 17, 2020

NitinBhasneria commented Feb 18, 2020 • edited Loading

cesswairimu commented Feb 19, 2020

cesswairimu commented Feb 19, 2020

NitinBhasneria commented Feb 19, 2020

NitinBhasneria commented Feb 19, 2020

NitinBhasneria commented Feb 19, 2020

cesswairimu commented Feb 19, 2020

NitinBhasneria commented Feb 19, 2020 • edited Loading

cesswairimu commented Feb 19, 2020

NitinBhasneria commented Feb 19, 2020 • edited Loading

cesswairimu commented Feb 19, 2020

NitinBhasneria commented Feb 19, 2020

cesswairimu commented Feb 19, 2020

NitinBhasneria commented Feb 19, 2020 • edited Loading

cesswairimu commented Feb 19, 2020

NitinBhasneria commented Feb 19, 2020

cesswairimu commented Feb 19, 2020

NitinBhasneria commented Feb 19, 2020

plotsbot commented Feb 19, 2020

7522-test_questions.png

7522-test_embeddable_grids.png

7522-test_signup.png

7522-test_viewing_the_settings_page.png

7522-test_tag_by_author_page.png

7522-test_wiki_page_with_inline_grids.png

7522-test_stats.png

7522-test_viewing_the_dashboard.png

7522-test_searching_an_item_from_the_homepage.png

7522-test_signup_modal_form_validation.png

7522-test_tag_stats.png

7522-test_login_modal_form_validation.png

7522-test_questions_shadow.png

7522-test_login_modal.png

7522-test_profile_page.png

7522-test_comments.png

7522-test_tags.png

7522-test_signup_modal.png

7522-test_wiki.png

7522-test_methods.png

7522-test_tag_page.png

7522-test_blog_page_with_location_modal.png

7522-test_tag_wildcard.png

7522-test_signup_modal_disabled_submit_button_on_empty_username.png

7522-test_embeddable_thumbnail_grids.png

7522-test_front_page_with_navbar_search_autocomplete.png

7522-failures_test_following_the_wiki_author.png

7522-test_spam_moderation_page.png

7522-test_login.png

7522-test_viewing_the_dropdown_menu.png

7522-test_viewing_question_post.png

7522-test_mobile_displays.png

7522-test_simple-data-grapher_powertag.png

7522-test_front.png

7522-test_question_page.png

7522-test_tag_contributors_page.png

7522-test_blog.png

7522-test_people.png

7522-test_wiki_revisions.png

NitinBhasneria commented Mar 1, 2020

cesswairimu commented Mar 2, 2020 • edited Loading

NitinBhasneria commented Mar 2, 2020

VladimirMikulic commented Mar 2, 2020

cesswairimu commented Mar 3, 2020

NitinBhasneria commented Mar 9, 2020

cesswairimu commented Mar 15, 2020

NitinBhasneria commented Apr 5, 2020

cesswairimu left a comment

Choose a reason for hiding this comment

cesswairimu commented Sep 18, 2020

cesswairimu commented Oct 29, 2020

codecov bot commented Feb 17, 2020 •

edited

Loading

NitinBhasneria commented Feb 18, 2020 •

edited

Loading

NitinBhasneria commented Feb 19, 2020 •

edited

Loading

NitinBhasneria commented Feb 19, 2020 •

edited

Loading

NitinBhasneria commented Feb 19, 2020 •

edited

Loading

cesswairimu commented Mar 2, 2020 •

edited

Loading