Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize /contributors/___ pages #6304

Closed
2 tasks
jywarren opened this issue Sep 16, 2019 · 14 comments · Fixed by #10794
Closed
2 tasks

Reorganize /contributors/___ pages #6304

jywarren opened this issue Sep 16, 2019 · 14 comments · Fixed by #10794
Labels
design issue requires more design work and discussion (i.e. mockups and sketches) feature explains that the issue is to add a new feature help wanted requires help by anyone willing to contribute
Milestone
User interface (UI)

Comments

@jywarren
Copy link
Member

(follow-up to #5632) cc @IshaGupta18 🙌

We now show 2 types of users on our contributor pages like https://publiclab.org/contributors/water-quality

  1. contributors - who have posted using this topic or commented on this topic
  2. followers - who are following this topic and will get notified when new content is posted to it

They're a bit messily next to each other:

image

Let's:

  • show contributors in a table on top, but in each row, mark if that person is ALSO following -- maybe, with an eye icon? In a column called Following, maybe?)
  • then let's show people who are NOT in the first list, but ARE subscribed. This can be in a second table with the title Following.

Should we have a short text explanation of the distinction?
@jywarren jywarren added design issue requires more design work and discussion (i.e. mockups and sketches) feature explains that the issue is to add a new feature labels Sep 16, 2019
@jywarren jywarren mentioned this issue Sep 16, 2019
Closed
@ebarry
Copy link
Member

ebarry commented Sep 16, 2019

great plan!

@Anupam-dagar
Copy link
Member

@jywarren I would like to take this up.

@IshaGupta18
Copy link
Collaborator

Go ahead! Let me know if you need some help!

@Anupam-dagar
Copy link
Member

@jywarren Can we include a badge in front of the user's name in the contributors table to signify following or maybe coloring the row?

@IshaGupta18
Copy link
Collaborator

IshaGupta18 commented Sep 27, 2019 via email

@jywarren
Copy link
Member Author

If there is a unique column for the indicator, that'd be great, so it has a header label. But within that column, I think a badge with the <i class="fa fa-eye"></i> icon could work! What do you think?

@jywarren jywarren added this to the User interface (UI) milestone Sep 27, 2019
@jywarren
Copy link
Member Author

Hi, how is this coming along, did you need any help? Thanks!

@jywarren jywarren mentioned this issue Nov 26, 2019
Closed
@jywarren jywarren added the help wanted requires help by anyone willing to contribute label Jan 3, 2020
@NitinBhasneria
Copy link
Collaborator

@nstjean I don't know how to check whether the person is following or not. Do you know how to check?

@NitinBhasneria NitinBhasneria mentioned this issue Feb 17, 2020
Closed
5 tasks
@nstjean
Copy link
Contributor

nstjean commented Feb 17, 2020

That is a good question. Let me take a look!

@NitinBhasneria
Copy link
Collaborator

I have made a pr for this just have a look.
@nstjean

@stale stale bot added the stale label Oct 7, 2020
@publiclab publiclab deleted a comment from stale bot Oct 8, 2020
@stale stale bot removed the stale label Oct 8, 2020
@KarishmaVanwari
Copy link
Contributor

Is this issue open? @jywarren @ebarry @IshaGupta18

@TildaDares
Copy link
Member

Hi @KarishmaVanwari, it still is.

KarishmaVanwari added a commit to KarishmaVanwari/plots2 that referenced this issue Mar 11, 2022
@KarishmaVanwari
Fixes publiclab#6304: Added eye icon for contributors that are follow…
3bdeaf0 
…ing too
@KarishmaVanwari KarishmaVanwari mentioned this issue Mar 11, 2022
Closed
5 tasks
@KarishmaVanwari
Copy link
Contributor

@TildaDares I've opened a PR #10778. Please have a look!

KarishmaVanwari added a commit to KarishmaVanwari/plots2 that referenced this issue Mar 18, 2022
@KarishmaVanwari
Fixes publiclab#6304: Added eye icon for contributors that are follow…
02d690b 
…ing too
@KarishmaVanwari KarishmaVanwari mentioned this issue Mar 18, 2022
Merged
5 tasks
@KarishmaVanwari
Copy link
Contributor

@TildaDares I've created another PR #10778. Please review. Apologies for the inconvenience.

jywarren pushed a commit that referenced this issue Mar 30, 2022
@KarishmaVanwari
Fixes #6304: Added eye icon for contributors that are following too (#…
ef80bdd 
…10794)

* Fixes #6304: Added eye icon for contributors that are following too

* Added 'Following' tooltip over the eye icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design issue requires more design work and discussion (i.e. mockups and sketches) feature explains that the issue is to add a new feature help wanted requires help by anyone willing to contribute
Projects
None yet
Milestone
User interface (UI)
8 participants
@jywarren @ebarry @Anupam-dagar @IshaGupta18 @NitinBhasneria @nstjean @TildaDares @KarishmaVanwari