Fixes #6304: Added eye icon for contributors that are following too #10778
Conversation
|
|
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
app/views/tag/_contributors.html.erb
Outdated
| </div> | ||
| </div> | ||
| <br /> | ||
| <% end %> |
There was a problem hiding this comment.
Hi @KarishmaVanwari, I think your linter/formatter added more changes than necessary.
There was a problem hiding this comment.
Hi @TildaDares. I have sucessfully ran the linting commands and committed as well. So shall I need to squash my commits as well.
There was a problem hiding this comment.
Hi @KarishmaVanwari, the changes are still there.
There was a problem hiding this comment.
Yes @TildaDares. I'll close this PR and create another one. Apologies for the inconvenience.
|
Code Climate has analyzed commit 1337e2e and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #10778 +/- ##
==========================================
+ Coverage 82.32% 82.33% +0.01%
==========================================
Files 98 98
Lines 5990 5990
==========================================
+ Hits 4931 4932 +1
+ Misses 1059 1058 -1
|
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
@TildaDares Closing this PR since I've created another PR #10794 |
An eye icon now appears right beside the name of the contributor if it is following too.
Fixes #6304
Screeenshot:
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment below