Adding a followers column to tag page #5632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gauravano here is the new PR after the bootstrap upgrade. Please review this one and let me know what else can be done! |
grvsachdeva
reviewed
Apr 30, 2019
|
Hey, what exactly am I supposed to fix here? Sorry didn't understand a little! Thanks! |
|
@gauravano could you tell me what all is left in this so that I can finish it off and merge this PR? |
|
I think Gaurav thought perhaps that was a stray |
|
Hi, Isha! Do you think this could be wrapped up pretty easily? Thank you! |
|
Sure, can you please tell what else needs to be done? Let's get it closed!
…On Fri, Sep 6, 2019, 2:30 AM Jeffrey Warren ***@***.***> wrote:
Hi, Isha! Do you think this could be wrapped up pretty easily? Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5632?email_source=notifications&email_token=AJXHQZ42AY4H7ET4VAYR3JDQIFXPNA5CNFSM4HJAOCTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6AXZFQ#issuecomment-528579734>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJXHQZ4BYRKCOXXD32FVIRLQIFXPNANCNFSM4HJAOCTA>
.
|
|
Just resolving the conflicts, so not much! Thanks!!!
…On Thu, Sep 5, 2019, 5:10 PM Isha Gupta ***@***.***> wrote:
Sure, can you please tell what else needs to be done? Let's get it closed!
On Fri, Sep 6, 2019, 2:30 AM Jeffrey Warren ***@***.***>
wrote:
> Hi, Isha! Do you think this could be wrapped up pretty easily? Thank you!
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#5632?email_source=notifications&email_token=AJXHQZ42AY4H7ET4VAYR3JDQIFXPNA5CNFSM4HJAOCTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6AXZFQ#issuecomment-528579734
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AJXHQZ4BYRKCOXXD32FVIRLQIFXPNANCNFSM4HJAOCTA
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5632?email_source=notifications&email_token=AAAF6J2BDITROTNYZHILPV3QIFYQ5A5CNFSM4HJAOCTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6AYTBQ#issuecomment-528583046>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J77YVXY7XMTGK6DZJLQIFYQ5ANCNFSM4HJAOCTA>
.
|
|
@jywarren is it good to go? |
|
Sorry @IshaGupta18, this looks great! I'm just going to add a screenshot test so we can see it rendered on the new page style. Just a final check and it'll be good to get this in our screenshot tests system anyways! |
|
Yes, absolutely!
…On Mon, Sep 16, 2019, 9:08 PM Jeffrey Warren ***@***.***> wrote:
Sorry @IshaGupta18 <https://github.com/IshaGupta18>, this looks great!
I'm just going to add a screenshot test so we can see it rendered on the
new page style. Just a final check and it'll be good to get this in our
screenshot tests system anyways!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5632?email_source=notifications&email_token=AJXHQZ5FVNM7TWJWMZDRUD3QJ6SA7A5CNFSM4HJAOCTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6ZSFFQ#issuecomment-531833494>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJXHQZZVMUWVYARQ6QREJWTQJ6SA7ANCNFSM4HJAOCTA>
.
|
|
Unrelated timing issue! Let's see... |
Screenshots 📸 (click to expand)5632-test_viewing_question_post.png5632-test_signup_modal.png5632-test_wiki.png5632-test_tag_page.png5632-test_searching_an_item_from_the_homepage.png5632-test_blog_page_with_location_modal.png5632-test_login.png5632-test_wiki_page_with_inline_grids.png5632-test_questions.png5632-test_methods.png5632-test_tag_by_author_page.png5632-test_viewing_the_dropdown_menu.png5632-test_simple-data-grapher_powertag.png5632-test_viewing_the_settings_page.png5632-test_login_modal.png5632-test_comments.png5632-test_stats.png5632-test_tags.png5632-test_wiki_revisions.png5632-test_people.png5632-test_tag_contributors_page.png5632-test_front.png5632-test_signup.png5632-test_questions_shadow.png5632-test_blog.png5632-test_question_page.png5632-test_front_page_with_navbar_search_autocomplete.png5632-test_tag_wildcard.png5632-test_viewing_the_dashboard.pngLearn about automated screenshots Generated by 🚫 Danger |
|
It passes @jywarren! |
|
Great! This is pending discussion by @ebarry and others but we should open a follow-up issue to this where we can redo the design of the page a bit -- but of course we can do this in a separate PR! Thank you! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5089
Movie from #5353 after the bootstrap upgrade: