Lines of header improved #7312

[NitinBhasneria]

Fixes #7312
Line on header at width 768px #7312
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[codecov]

Codecov Report

Merging #7445 into master will increase coverage by 26.91%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #7445       +/-   ##
===========================================
+ Coverage   54.98%   81.90%   +26.91%     
===========================================
  Files          97       97               
  Lines        6965     5615     -1350     
===========================================
+ Hits         3830     4599      +769     
+ Misses       3135     1016     -2119     

Impacted Files	Coverage Δ
app/models/user.rb	91.05% <0.00%> (+1.94%)	⬆️
app/models/node.rb	90.90% <0.00%> (+2.41%)	⬆️
app/models/comment.rb	76.89% <0.00%> (+2.42%)	⬆️
app/helpers/application_helper.rb	84.52% <0.00%> (+5.95%)	⬆️
app/controllers/application_controller.rb	92.30% <0.00%> (+5.98%)	⬆️
app/models/drupal_file.rb	36.84% <0.00%> (+9.91%)	⬆️
app/services/search_criteria.rb	95.74% <0.00%> (+12.76%)	⬆️
app/api/srch/search.rb	65.35% <0.00%> (+13.07%)	⬆️
app/models/drupal_content_field_image_gallery.rb	66.66% <0.00%> (+19.04%)	⬆️
app/services/search_service.rb	95.14% <0.00%> (+20.38%)	⬆️
... and 31 more

[VladimirMikulic]

Good work @NitinBhasneria. Thanks.

[NitinBhasneria]

@cesswairimu can you approve and merge this pr please?

[NitinBhasneria]

@nstjean Can you have a look at this and review this, please.

[nstjean]

I do see the slight line in the header. However I'm not sure adjusting the media query is the best tactic. It is better to figure out what's causing that line to appear, it could be something that pops up again down the road.

[NitinBhasneria]

I do see the slight line in the header. However I'm not sure adjusting the media query is the best tactic. It is better to figure out what's causing that line to appear, it could be something that pops up again down the road.

I think the media query is the reason because the navbar of width less then 576 and greater then 576px both appears at 576px due to this the line appears

[nstjean]

But we don't know what CSS is causing the line. A media query doesn't do anything by itself, it just tells the browser which CSS to use. If there's a line then something is creating it.

[NitinBhasneria]

Then I will look at it once more.

[SidharthBansal]

Ping me when done!
Thanks all

[NitinBhasneria]

@nstjean I got where were the CSS error and I have removed the unnecessary CSS. Review it @SidharthBansal @cesswairimu @nstjean

[cesswairimu]

Sorry @NitinBhasneria I now understand the line you were talking about. Can we get a screenshot after this change? Also please rebase so that travis can pass. Thanks

[NitinBhasneria]

@cesswairimu
Here is the screenshot, also I am done with rebasing.

[cesswairimu]

Great, thanks

[cesswairimu]

Thanks @NitinBhasneria