-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
following table aligned in contributor page #7331
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7331 +/- ##
==========================================
+ Coverage 81.73% 81.87% +0.13%
==========================================
Files 97 97
Lines 5602 5612 +10
==========================================
+ Hits 4579 4595 +16
+ Misses 1023 1017 -6
|
Can anyone tell me why this check is showing error |
@jywarren @SidharthBansal @nstjean can you please tell me why this check is not successful and how to fix this |
@keshav234156 It looks like an error, not your fault! @jywarren can you restart this test? |
@nstjean looks like you wanted to mention @keshavsethi instead of @keshav234156 (me)!!! |
Whoops so sorry! |
Closing and Opening the pr is the simplest way to restart the travis if you don't have access |
Oh, ok! Thank you for the tip! |
Can we merge this? @nstjean @SidharthBansal |
Screenshots 📸 (click to expand)7331-test_questions.png7331-test_embeddable_grids.png7331-test_signup.png7331-test_viewing_the_settings_page.png7331-test_tag_by_author_page.png7331-test_wiki_page_with_inline_grids.png7331-test_stats.png7331-test_viewing_the_dashboard.png7331-test_searching_an_item_from_the_homepage.png7331-test_signup_modal_form_validation.png7331-test_tag_stats.png7331-test_login_modal_form_validation.png7331-test_questions_shadow.png7331-test_login_modal.png7331-test_profile_page.png7331-test_comments.png7331-test_tags.png7331-test_signup_modal.png7331-test_wiki.png7331-test_methods.png7331-test_tag_page.png7331-test_blog_page_with_location_modal.png7331-test_tag_wildcard.png7331-test_signup_modal_disabled_submit_button_on_empty_username.png7331-test_embeddable_thumbnail_grids.png7331-test_front_page_with_navbar_search_autocomplete.png7331-test_spam_moderation_page.png7331-test_login.png7331-test_viewing_the_dropdown_menu.png7331-test_viewing_question_post.png7331-test_mobile_displays.png7331-test_simple-data-grapher_powertag.png7331-test_front.png7331-test_question_page.png7331-test_tag_contributors_page.png7331-test_blog.png7331-test_people.png7331-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
@keshavsethi I'm thinking maybe we should put some more space between the two columns. Glancing at it it seems a little confusing. Do you think you can modify that? |
thanks @keshavsethi |
Fixes #7297
![Screenshot from 2020-01-23 15-27-14](https://user-images.githubusercontent.com/36025262/72975482-e0252000-3df6-11ea-9aae-26bd91c6facd.png)
Here following section is properly aligned
This is what I am getting please review this.
Thanks!