Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: consider renaming internal/contour/v2 to something more descriptive #2939

Closed
skriss opened this issue Sep 23, 2020 · 1 comment · Fixed by #2949
Closed

internal: consider renaming internal/contour/v2 to something more descriptive #2939

skriss opened this issue Sep 23, 2020 · 1 comment · Fixed by #2949
Assignees
@stevesloka
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@skriss
Copy link
Member

skriss commented Sep 23, 2020

The XDS caches have now been extracted to their own package, internal/contour/v2. Consider renaming this package to something more descriptive, for example internal/xdscache/v2.
@skriss skriss added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 23, 2020
@skriss skriss mentioned this issue Sep 23, 2020
Merged
@stevesloka
Copy link
Member

I think this makes sense to me @skriss and further helps to clarify what this package is really doing. 🎉

@skriss skriss mentioned this issue Sep 23, 2020
Closed
@stevesloka stevesloka self-assigned this Sep 24, 2020
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 24, 2020
@stevesloka
interal: Update contour package to xdscache and rename imports
3eee4df 
Renames the `contour` package to `xdscache` and fixes up all the imports
to make them consistent across the project.

Fixes projectcontour#2938
Fixes projectcontour#2939

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 24, 2020
@stevesloka
internal: Update contour package to xdscache and rename imports
cf7bdc8 
Renames the `contour` package to `xdscache` and fixes up all the imports
to make them consistent across the project.

Fixes projectcontour#2938
Fixes projectcontour#2939

Signed-off-by: Steve Sloka <slokas@vmware.com>
@stevesloka stevesloka mentioned this issue Sep 24, 2020
Closed
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 24, 2020
@stevesloka
internal: Update contour package to xdscache and rename imports
d2851fe 
Renames the `contour` package to `xdscache` and fixes up all the imports
to make them consistent across the project.

Fixes projectcontour#2938
Fixes projectcontour#2939

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 29, 2020
@stevesloka
Renames the internal/contour package to internal/xdscache.
d1957bc 
Fixes projectcontour#2939

Signed-off-by: Steve Sloka <slokas@vmware.com>
@stevesloka stevesloka mentioned this issue Sep 29, 2020
Merged
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 29, 2020
@stevesloka
Renames the internal/contour package to internal/xdscache.
8c32370 
Fixes projectcontour#2939

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 29, 2020
@stevesloka
Creates a new internal/xdscache package and move some files from inte…
93ab567 
…rnal/contour package into.

Fixes projectcontour#2939

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka added a commit that referenced this issue Sep 29, 2020
@stevesloka
Creates a new internal/xdscache package and move some files from inte…
53ddcc6 
…rnal/contour package into. (#2949)

Fixes #2939

Signed-off-by: Steve Sloka <slokas@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevesloka stevesloka

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
2 participants
@stevesloka @skriss