Introduce xdscache package to handle xds cache resources #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2949 +/- ##
==========================================
- Coverage 76.45% 75.14% -1.31%
==========================================
Files 74 87 +13
Lines 5806 5678 -128
==========================================
- Hits 4439 4267 -172
- Misses 1272 1317 +45
+ Partials 95 94 -1
|
skriss
requested changes
Sep 29, 2020
There was a problem hiding this comment.
Just looking at this again, mostly LGTM, but there are a few types that I don't think really belong under an internal/xdscache package - I think it'd make sense to leave them in internal/contour for now and we can decide if they should move somewhere else separately.
cmd/contour/serve.go
Outdated
|
|
||
| dnsLookupFamily, err := ParseDNSLookupFamily(ctx.DNSLookupFamily) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to configure configuration file parameter cluster.dns-lookup-family: %w", err) | ||
| } | ||
|
|
||
| // Build the core Kubernetes event handler. | ||
| eventHandler := &contour.EventHandler{ | ||
| eventHandler := &xdscache.EventHandler{ |
There was a problem hiding this comment.
I'd probably leave the EventHandler type in the internal/contour package, not sure it makes sense under xdscache.
cmd/contour/serve.go
Outdated
| @@ -339,7 +339,7 @@ func doServe(log logrus.FieldLogger, ctx *serveContext) error { | |||
| // Wrap eventHandler in a converter for objects from the dynamic client. | |||
| // and an EventRecorder which tracks API server events. | |||
| dynamicHandler := &k8s.DynamicClientHandler{ | |||
| Next: &contour.EventRecorder{ | |||
| Next: &xdscache.EventRecorder{ | |||
There was a problem hiding this comment.
EventRecorder seems like another one that should probably stay where it is.
cmd/contour/serve.go
Outdated
| @@ -444,7 +444,7 @@ func doServe(log logrus.FieldLogger, ctx *serveContext) error { | |||
|
|
|||
| // Once we have the leadership detection channel, we can | |||
| // push DAG rebuild metrics onto the observer stack. | |||
| eventHandler.Observer = &contour.RebuildMetricsObserver{ | |||
| eventHandler.Observer = &xdscache.RebuildMetricsObserver{ | |||
There was a problem hiding this comment.
RebuildMetricsObserver - keep in internal/contour?
stevesloka
force-pushed
the
moveContourPackage
branch
from
d1957bc
to
8c32370
Compare
|
Probably should update the commit msg/PR title since the whole package isn't being renamed. |
…rnal/contour package into. Fixes projectcontour#2939 Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka
force-pushed
the
moveContourPackage
branch
from
8c32370
to
93ab567
Compare
stevesloka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2939
Signed-off-by: Steve Sloka slokas@vmware.com