internal: Update contour package to xdscache and rename imports #2941
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2941 +/- ##
=======================================
Coverage 74.91% 74.91%
=======================================
Files 87 87
Lines 5604 5604
=======================================
Hits 4198 4198
Misses 1315 1315
Partials 91 91
|
There was a problem hiding this comment.
This looks reasonable to me. It'd be helpful to document this standard, perhaps in https://github.com/projectcontour/contour/blob/main/CONTRIBUTING.md -- I'd like to see us document a few more of the conventions and standards that we use there, it's helpful for new contributors.
|
Also, this is probably going to conflict with a few open PRs...not sure what order we want to go in. |
Renames the `contour` package to `xdscache` and fixes up all the imports to make them consistent across the project. Fixes projectcontour#2938 Fixes projectcontour#2939 Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka
force-pushed
the
renameContourPackage
branch
from
cf7bdc8
to
d2851fe
Compare
|
Ah, oops, I forgot to check. The status change should be straightforward to fix. I won't merge anything more until this one is done - I think this should go next. |
|
I merged the CORS PR, this is now ready for a rebase. |
|
Both of the linked issues seem reasonable to be, but can we make separate PRs for them? Is there a good reason that we need to combine both large changes? |
Nope no real reason other than making the review easier. The rename touches the same number of files as the package move, so the attempt was to make it easier on the reviewer to only validate the alias import changes. |
|
The merge conflicts got to me trying to resolve, it will be easier to just do the work again from scratch. I'll split into two as well for @jpeach. |
Renames the
contourpackage toxdscacheand fixes up all the importsto make them consistent across the project.
Fixes #2938
Fixes #2939
Signed-off-by: Steve Sloka slokas@vmware.com