internal/contour: Refactor v2 contour files into v2 package #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2928 +/- ##
=======================================
Coverage 74.91% 74.91%
=======================================
Files 87 87
Lines 5604 5604
=======================================
Hits 4198 4198
Misses 1315 1315
Partials 91 91
|
stevesloka
force-pushed
the
refactorContourv2
branch
from
88087be
to
bd45169
Compare
|
ready for a rebase |
stevesloka
force-pushed
the
refactorContourv2
branch
from
bd45169
to
f4cecd8
Compare
|
all rebased @skriss |
Refactors the contour package into a v2 package for Envoy API V2 types. Common items are kept in the contour package for use by other versions. This doesn't change anything functionally, just refactors contour into a v2 package. Updates: projectcontour#1898 Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka
force-pushed
the
refactorContourv2
branch
from
f4cecd8
to
8056161
Compare
skriss
approved these changes
Sep 23, 2020
| @@ -29,6 +29,7 @@ import ( | |||
| contourv1 "github.com/projectcontour/contour/apis/projectcontour/v1" | |||
| "github.com/projectcontour/contour/internal/annotation" | |||
| "github.com/projectcontour/contour/internal/contour" | |||
| contourv2 "github.com/projectcontour/contour/internal/contour/v2" | |||
There was a problem hiding this comment.
it's a little unfortunate that contourv1 refers to the API package, while contourv2 refers to the internal package. We could use contourv1api or similar for the former. Not blocking.
|
I also opened #2939 for the other naming-related comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the contour package into a v2 package for Envoy API V2 types.
Common items are kept in the contour package for use by other versions.
This doesn't change anything functionally, just refactors contour into a v2 package.
Updates: #1898
Blocked waiting on #2921 to merge.