Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Envoy xDS v3. #1898

Closed
jpeach opened this issue Nov 13, 2019 · 7 comments
Closed

Add support for Envoy xDS v3. #1898

jpeach opened this issue Nov 13, 2019 · 7 comments
Assignees
@stevesloka
Labels
priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
1.11.0

Comments

@jpeach
Copy link
Contributor

jpeach commented Nov 13, 2019

A year after Envoy ships xDS v3, they plan to remove support for v2. It's not entirely clear to me what that entails, but it seems likely we will need to add and qualify v3 support and maybe support v2 at the same time.

See envoyproxy/envoy#6271
@jpeach jpeach added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. blocked/needs-envoy Categorizes the issue or PR as blocked because it needs changes in Envoy. labels Nov 13, 2019
@jpeach jpeach added this to the Backlog milestone Nov 13, 2019
@jpeach
Copy link
Contributor Author

jpeach commented Jan 20, 2020

Related to #2132

@jpeach
Copy link
Contributor Author

jpeach commented May 7, 2020

xref envoyproxy/envoy#10943

@jpeach jpeach mentioned this issue Jul 31, 2020
Closed
@jpeach jpeach removed the blocked/needs-envoy Categorizes the issue or PR as blocked because it needs changes in Envoy. label Jul 31, 2020
This was referenced Aug 7, 2020
Closed
Open
@youngnick youngnick mentioned this issue Sep 7, 2020
Closed
@bgagnon
Copy link
Contributor

bgagnon commented Sep 8, 2020 •
edited
Loading

According to https://www.envoyproxy.io/docs/envoy/latest/api/api_supported_versions, the V2 API will stop being supported at the end of this year. Seeing this issue is unprioritized, is Contour at risk of falling too far behind?

@skriss
Copy link
Member

skriss commented Sep 8, 2020

We should move this into Prioritized -- we're aware of the EOY deprecation deadline and are working towards adding v3 support.

@stevesloka
Copy link
Member

I'm going to poke around a bit to see how we might address this migration.

@bgagnon bgagnon mentioned this issue Sep 15, 2020
Open
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 17, 2020
@stevesloka
internal: Refactor Envoy into v2 package
8b69b88 
Refactors the envoy package into a v2 package for Envoy API V2 types.
Common items are kept in the envoy package for use by other versions.

Updates: projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
@stevesloka stevesloka mentioned this issue Sep 17, 2020
Merged
@stevesloka stevesloka self-assigned this Sep 18, 2020
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 18, 2020
@stevesloka
internal: Refactor Envoy into v2 package
e3f2faa 
Refactors the envoy package into a v2 package for Envoy API V2 types.
Common items are kept in the envoy package for use by other versions.

Updates: projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 20, 2020
@stevesloka
internal: Refactor Envoy into v2 package
aae453f 
Refactors the envoy package into a v2 package for Envoy API V2 types.
Common items are kept in the envoy package for use by other versions.

Updates: projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 20, 2020
@stevesloka
internal/contour: Refactor v2 contour files into v2 package
88087be 
Refactors the contour package into a v2 package for Envoy API V2 types.
Common items are kept in the contour package for use by other versions.

This doesn't change anything functionally, just refactors contour into a v2 package.

Updates: projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
@stevesloka stevesloka mentioned this issue Sep 20, 2020
Merged
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 21, 2020
@stevesloka
internal/contour: Refactor v2 contour files into v2 package
bd45169 
Refactors the contour package into a v2 package for Envoy API V2 types.
Common items are kept in the contour package for use by other versions.

This doesn't change anything functionally, just refactors contour into a v2 package.

Updates: projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 21, 2020
@stevesloka
internal/featuretests: Refactor into a v2 package
54f474b 
Refactors the featuretests package into a v2 package for Envoy API V2 types.
Common items are kept in the feature package for use by other versions.

Updates: projectcontour#1898
Signed-off-by: Steve Sloka <slokas@vmware.com>
@stevesloka stevesloka mentioned this issue Sep 21, 2020
Merged
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 23, 2020
@stevesloka
internal: Refactor Envoy into v2 package
5e59d52 
Refactors the envoy package into a v2 package for Envoy API V2 types.
Common items are kept in the envoy package for use by other versions.

Updates: projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 23, 2020
@stevesloka
internal: Refactor Envoy into v2 package
dd615d5 
Refactors the envoy package into a v2 package for Envoy API V2 types.
Common items are kept in the envoy package for use by other versions.

Updates: projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka added a commit that referenced this issue Sep 23, 2020
@stevesloka
internal: Refactor Envoy into v2 package (#2921)
d9bef78 
Refactors the envoy package into a v2 package for Envoy API V2 types.
Common items are kept in the envoy package for use by other versions.

Updates: #1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 23, 2020
@stevesloka
internal/contour: Refactor v2 contour files into v2 package
f4cecd8 
Refactors the contour package into a v2 package for Envoy API V2 types.
Common items are kept in the contour package for use by other versions.

This doesn't change anything functionally, just refactors contour into a v2 package.

Updates: projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka added a commit to stevesloka/contour that referenced this issue Nov 10, 2020
@stevesloka
internal: Drop support for v2 xDS resource version
50313df 
Drop support for xDS v3 resource version by changing the default
boostrap resource version to v3 and removing the v2 xDS resource server.

Updates projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka added a commit to stevesloka/contour that referenced this issue Nov 10, 2020
@stevesloka
internal/envoy: Enable xDS v3 Clusters
04acb5d 
Enables v3 xDS Clusters as well as supporting structs.

Updates projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
@stevesloka stevesloka mentioned this issue Nov 10, 2020
Closed
stevesloka added a commit to stevesloka/contour that referenced this issue Nov 10, 2020
@stevesloka
internal/envoy: Enable xDS v3 Clusters
6c8e20f 
Enables v3 xDS Clusters as well as supporting structs.

Updates projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka added a commit to stevesloka/contour that referenced this issue Nov 11, 2020
@stevesloka
internal/envoy: Move remaining methods from envoy/v2/endpoints to env…
44bf5bf 
…oy/v3/endpoints

Updates projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
@stevesloka stevesloka mentioned this issue Nov 11, 2020
Closed
stevesloka added a commit to stevesloka/contour that referenced this issue Nov 11, 2020
@stevesloka
internal: Refactor common bits from envoy/listeners
044e6e1 
Updates projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka added a commit to stevesloka/contour that referenced this issue Nov 11, 2020
@stevesloka
internal: Refactor common bits from envoy/listeners
8528d61 
Updates projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
This was referenced Nov 11, 2020
Closed
Merged
stevesloka added a commit to stevesloka/contour that referenced this issue Nov 12, 2020
@stevesloka
remove remaining xDS resource v2 server and related converters
23a3e91 
Updates projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
@stevesloka stevesloka mentioned this issue Nov 12, 2020
Merged
stevesloka added a commit that referenced this issue Nov 12, 2020
@stevesloka
internal: Migrate all v2 xDS resource versions to v3 for package int…
3e0cafd 
…ernal/envoy/v3 (#3118)

internal: Migrate all v2 xDS resource versions to v3 for package internal/envoy/v3

Updates #1898 

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka added a commit to stevesloka/contour that referenced this issue Nov 12, 2020
@stevesloka
internal/featuretests: Move xDS version v2 to v3 features tests
9419e61 
Updates projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
@stevesloka stevesloka mentioned this issue Nov 12, 2020
Merged
skriss added a commit to skriss/contour that referenced this issue Nov 12, 2020
@skriss
switch from v2 to v3 xDS caches
2c1cb61 
Switches from v2 xds caches to v3 xds caches for observing
the DAG and backing the v3 xDS server.

Updates projectcontour#1898.

Signed-off-by: Steve Kriss <krisss@vmware.com>
stevesloka added a commit that referenced this issue Nov 13, 2020
@stevesloka
internal/featuretests: Move xDS version v2 to v3 features tests (#3124)
e0fcb27 
Updates #1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka pushed a commit that referenced this issue Nov 13, 2020
@skriss
switch from v2 to v3 xDS caches (#3123)
75a7e0c 
internal: switch from v2 to v3 xDS caches

Switches from v2 xds caches to v3 xds caches for observing
the DAG and backing the v3 xDS server.

Updates #1898

Signed-off-by: Steve Kriss <krisss@vmware.com>
stevesloka added a commit to stevesloka/contour that referenced this issue Nov 13, 2020
@stevesloka
remove remaining xDS resource v2 server and related converters
5477b71 
Updates projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka added a commit to stevesloka/contour that referenced this issue Nov 13, 2020
@stevesloka
remove remaining xDS resource v2 server and related converters
81b9be2 
Updates projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka added a commit that referenced this issue Nov 13, 2020
@stevesloka
remove remaining xDS resource v2 server and related converters (#3119)
35e2013 
Updates #1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Nov 16, 2020
@skriss
internal/sorter: remove xDS v2 sorters
96a9388 
Updates projectcontour#1898.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss mentioned this issue Nov 16, 2020
Merged
stevesloka pushed a commit that referenced this issue Nov 16, 2020
@skriss
internal/sorter: remove xDS v2 sorters (#3128)
4f893a6 
Updates #1898.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss modified the milestones: Backlog, 1.11.0 Nov 16, 2020
@skriss
Copy link
Member

skriss commented Nov 16, 2020

@stevesloka think we can consider this closed now?

@stevesloka
Copy link
Member

Yup I think so! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevesloka stevesloka

Labels
priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
1.11.0
Development

No branches or pull requests
4 participants
@jpeach @bgagnon @stevesloka @skriss