Rendering [Step1]: Merge Rendering Module #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(Migration): - Migrated Apollo SDK and omsdk modules to prebid - Migrated GAM event handlers and mopub adapters modules - Migrated internal test app - Added TestUtils module and included it in SDK and GAM event handlers - Using gradle.properties in each module to enable androidx support - Added fastlane and jenkins scripts - Updated gradle plugin and fixed issues after update
refactoring: - Rename Test app module and package names - Rename Rendering module and package names - Rename GAM event handlers module and package names - Update package name reference in layout files - Remove mentions of apollo and openx - Rename PPM to In-App - Remove openx icon
* feat(PrebidRenderingSettings): - Added ability to change bidServerHost refactoring(DemoRenderingKotlin) - Replaced reflection usage for setting bid server host tests: - Added unit test to verify that bid server host was changed (if not empty) * refactoring(PrebidInternalTestApp): - Rename prebid rendering demo app module * feat(PrebidRenderingSettings): - Introduced Host enum with RUBICON, APPNEXUS and CUSTOM values - Added ability to set custom host through HOST enum - Added host url validation to fetchDemand tests: - Added unit test to verify fetch demand error on invalid custom host - Applied change to unit tests that rely on bid server host
* refactoring: - Removed mentions of OpenX and apollo where possible - Renaming classes and methods with openx prefixes - Renaming Gamutils methods - Renaming tests and removing openx mentions from resources - Renaming test utils package to org.prebid.mobile.test * fix(ui tests): - Applied changes for GAM UI tests to work until config changes are applied
refactoring(Mockito): - Update mockito version and applied changes for tests
* refactoring(AppEvents): - Changed app events constant - Removed unneeded event field from utils * refactoring(MoPub adapters): - Changed adapter names to prebid - Removed mentions of apollo / openx
chore(copyright): - Added prebid copyright to rendering modules
feat(UserConsentManager): - Added handling of device purpose consent - Cleanup unused variables feat(Requester): - Fetching ADID only if device consent is valid - Nullifying ADID if consent is not granted (in case it changed) tests(unit): - Added unit tests to verify consent behaviour
chore(OM SDK): - Replaced openx OM SDK with Prebid OM SDK - Updated imports
refactoring(GAM SDK v20): - Updated GAM SDK to v20 - Applied changes for RewardedAdWrapper, InterstitialWrapper, BannerWrapper - Applied changes to GamUtils - Applied changes to InternalTestApp - Removed GAM reflection from rendering SDK. Providing access without reflection in GamUtils - Renaming unified and customTemplate mentions tests(unit): - Applied GAM v20 changes to unit tests - Added isLoad tests to ad wrappers - Rename test methods
feat(MoPub adapters): - Updated mopub to 5.16.4 - Removed mopub dependency from rendering module - Remove deprecated classes from RV example tests(unit) - Moved tests with mopub dependency from rendering module to adapters module - Created dummy mopub view in tests to verify keywords are set - Added steps into dastfile to execute mopub adapter tests
refactoring(AdIndicator): - Removed AdIndicator classes and resources - Removed references to ad indicator tests: - Removed adIndicator unit / ui tests - Modified MraidExpand tests to avoid dialog show execution
feat(gradle.publish): - Added script to generate OM SDK POM - Added script to generate MoPub Adapters POM - Added script to generate GAM EH SDK POM - Added script to generate rendering SDK POM - Added shared build script to reduce duplication feat(gradle): - Renaming and moving common properties to project ext feat(deployPrebidMobile): - Simplifying script by extracting maven publishing into a separate function - Added artifact generation and moving them to generated folder alongside prebid artifacts
* refactoring: - Remove mentions of OXM, OXA, OX, OXB prefixes in source code * refactoring: - Rename PbLog into LogUtil
- Fixed mkdir command failure due */META-INF folder exists
- Change deviceConsent index to 0 and modified unit tests.
* chore(request): - Added "adslot" to imp.ext.context.data.adslot - Added API for setting pbAdSlot - Added "storedauctionresponse" and "storedbidresponse" support and API - Added unit tests * chore(Targeting): - Removed possibility to set targeting for carrier and ip
feat(NativeAdUnit): - Appending omid tracker on adunit creation tests: - Added test to verify event tracker list contains OMID event
- Added gdpr helper class to work with updating iab values - Added switch to change state of GDPR - Disabling gdpr in ui tests
YuriyVelichkoPI
requested review from
YuriyVelichkoPI and
ValentinPostindustria
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The strategy of applying rendering was changed. It was decided to provide rendering as a part of SDK but not as a separated module.
In the doc [PRD] Prebid Mobile SDK 1.13 Beta you can find more details.
As the first step of the new roadmap we need to get the codebase and modify it respectively. So this PR is intended to provide the codebase for rendering to Prebid.
Description
Details of the changes are described in the original PR for Rendering module:
prebid/prebid-mobile-ios#390
Future Steps