-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOBILE-7057: Remove OX OXB prefixes #14
MOBILE-7057: Remove OX OXB prefixes #14
Conversation
- Remove mentions of OXM, OXA, OX, OXB prefixes in source code
- Rename PbLog into LogUtil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, rename the Log file. Everything else looks good.
@@ -25,8 +25,8 @@ | |||
* When this is set as the head of the list, an instance of it can function as a drop-in replacement for {@link android.util.Log}. Most of the methods in this class server only to map a method call in Log to its equivalent in LogNode. | |||
* </p> | |||
*/ | |||
public class OXLog { | |||
private static final String TAG = OXLog.class.getSimpleName(); | |||
public class PbLog { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets use the same name for the Log class as in Prebid SDK - LogUtil.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* refactoring: - Remove mentions of OXM, OXA, OX, OXB prefixes in source code * refactoring: - Rename PbLog into LogUtil
* refactoring: - Remove mentions of OXM, OXA, OX, OXB prefixes in source code * refactoring: - Rename PbLog into LogUtil
refactoring:
NOTE: Example names and resources were not changed.