Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOBILE-7053: Update MoPub version in adapters #11

Conversation

KostiantynTselykh
Copy link

feat(MoPub adapters):

  • Updated mopub to 5.16.4
  • Removed mopub dependency from rendering module

tests(unit)

  • Moved tests with mopub dependency from rendering module to adapters module
  • Created dummy mopub view in tests to verify keywords are set
  • Added steps into dastfile to execute mopub adapter tests

- Updated mopub to 5.16.4
- Removed mopub dependency from rendering module
- Remove deprecated classes from RV example

tests(unit)
- Moved tests with mopub dependency from rendering module to adapters module
- Created dummy mopub view in tests to verify keywords are set
- Added steps into dastfile to execute mopub adapter tests
@KostiantynTselykh KostiantynTselykh force-pushed the MOBILE-7053_update_mopub_in_adapters branch from 2e31beb to 6be77c4 Compare April 22, 2021 08:50
Copy link

@YuriyVelichkoOpenX YuriyVelichkoOpenX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KostiantynTselykh KostiantynTselykh merged commit d5646bc into feature-rendering-module Apr 22, 2021
@KostiantynTselykh KostiantynTselykh deleted the MOBILE-7053_update_mopub_in_adapters branch April 22, 2021 12:08
KostiantynTselykh added a commit that referenced this pull request Apr 28, 2021
feat(MoPub adapters):
- Updated mopub to 5.16.4
- Removed mopub dependency from rendering module
- Remove deprecated classes from RV example

tests(unit)
- Moved tests with mopub dependency from rendering module to adapters module
- Created dummy mopub view in tests to verify keywords are set
- Added steps into dastfile to execute mopub adapter tests
KostiantynTselykh added a commit that referenced this pull request Apr 28, 2021
feat(MoPub adapters):
- Updated mopub to 5.16.4
- Removed mopub dependency from rendering module
- Remove deprecated classes from RV example

tests(unit)
- Moved tests with mopub dependency from rendering module to adapters module
- Created dummy mopub view in tests to verify keywords are set
- Added steps into dastfile to execute mopub adapter tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants