MOBILE-7049: Sync support of GDPR and CCPA #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KostiantynTselykh
requested review from
YuriyVelichkoOpenX and
VadimKhohlovOpenX
YuriyVelichkoOpenX
approved these changes
Apr 16, 2021
| final String subjectToGdpr = getSubjectToGdpr(); | ||
| final int deviceConsentIndex = 1; | ||
|
|
||
| Boolean gdprApplies = TextUtils.isEmpty(subjectToGdpr) ? null : "1".equals(subjectToGdpr); |
There was a problem hiding this comment.
For the future. If you start to use 'final' for some variables it makes sense to apply it everywhere. In this method, the first two variables have 'final' but these two don't have, somehow.
KostiantynTselykh
force-pushed
the
MOBILE-7049_sync_support_of_gdpr
branch
2 times, most recently
from
897a767
to
014bd49
Compare
- Added handling of device purpose consent - Cleanup unused variables feat(Requester): - Fetching ADID only if device consent is valid - Nullifying ADID if consent is not granted (in case it changed) tests(unit): - Added unit tests to verify consent behaviour
KostiantynTselykh
force-pushed
the
MOBILE-7049_sync_support_of_gdpr
branch
from
014bd49
to
22bc8c0
Compare
KostiantynTselykh
added a commit
that referenced
this pull request
Apr 28, 2021
feat(UserConsentManager): - Added handling of device purpose consent - Cleanup unused variables feat(Requester): - Fetching ADID only if device consent is valid - Nullifying ADID if consent is not granted (in case it changed) tests(unit): - Added unit tests to verify consent behaviour
KostiantynTselykh
added a commit
that referenced
this pull request
Apr 28, 2021
feat(UserConsentManager): - Added handling of device purpose consent - Cleanup unused variables feat(Requester): - Fetching ADID only if device consent is valid - Nullifying ADID if consent is not granted (in case it changed) tests(unit): - Added unit tests to verify consent behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(UserConsentManager):
feat(Requester):
tests(unit):