-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try/inline block commenting conflict resolve #65
Try/inline block commenting conflict resolve #65
Conversation
Co-authored-by: jeryj <jeryj@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org>
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: ockham <bernhard-reiter@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
…ordPress#65219) * Add JSDoc block for getSectionRootClientId in block editor * Apply suggestions from code review Co-authored-by: Dave Smith <getdavemail@gmail.com> --------- Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
… 2] (WordPress#65258) * Fix font library modal fonts to use 40px default button size * Fix install font button to use default 40px size * Fix the installed fonts button size to use 40px default * Fix upload font button size to use 40px default size * Fix add the default button 40px size for randomize color pallete button * Fix edit site style revision button to use 40px default size * Fix edit site shadow components buttons to use default 40px size * Fix the style for the button height on the font library modal * Add !important to override the button size for 40px Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
* Convert EmbedPreview component to functional component * Update interactive condition and move call inline versus within useEffect Unlinked contributors: louwie17. Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
…I Reference (WordPress#65375) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
…ess#65321) Bumps the react-native group with 2 updates in the / directory: [actions/setup-java](https://github.com/actions/setup-java) and [gradle/actions](https://github.com/gradle/actions). Updates `actions/setup-java` from 4.2.2 to 4.3.0 - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@6a0805f...2dfa201) Updates `gradle/actions` from 4.0.0 to 4.1.0 - [Release notes](https://github.com/gradle/actions/releases) - [Commits](gradle/actions@af1da67...d156388) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-minor dependency-group: react-native - dependency-name: gradle/actions dependency-type: direct:production update-type: version-update:semver-minor dependency-group: react-native ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: desrosj <desrosj@git.wordpress.org>
* Adds post type label to DocumentBar * Removes the post type icon from the DocumentBar * Try fixing one of the e2e tests * Remove IconType import and add typedef * Adds font-weight to heading and uses darker grey for constrast * Adjusts title overflow so it dosen't apply to post type label * Moves font weight to h1 * Try fixing more e2e tests * Fix another e2e * Add fix for mid screensizes when Back button is present * Hide post type label on small screen sizes --------- Co-authored-by: creativecoder <grantmkin@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org>
…anges from Core (WordPress#65259) Global Styles: Update REST controller override method: Update unit tests; Update class with Core's WP_REST_Global_Styles_Controller; Inherit WP_REST_Posts_Controller, make methods public et. al; Add 6.6+ post args to register post filter; Overwrite Core endpoints with $override when registering routes. --------- Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: spacedmonkey <spacedmonkey@git.wordpress.org>
* BoxControl: Add lint rule for 40px size prop usage * Add to readme Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
… apply (WordPress#65384) Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ajlende <ajlende@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org>
* Add __next40pxDefaultSize for files in editor 3 * Address feedback * change font size to 13 px * Revert classic-theme.js changes as it will be a seperate PR and revert 13px size in style as it is default * Wrap copy button in InputControlSuffixWrapper Co-authored-by: AKSHAT2802 <akshat2802@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
…ordPress#65377) * Remove duplicate keyframe definition across packages * Deprecate edit-post__fade-in-animation, replace with animation__fade-in * Add animation__fade-out mixin
* Fix vertical indicator * Add changelog entry Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
…nabled (WordPress#65372) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org>
* Combobox Control: Add placeholder attribute * Remove placeholder from default story * Change placeholder type description and add it to README * Add CHANGELOG entry
Fix issues where @wordpress/a11y script module `speak` may not be detected and announced by accessibility software, in particular when dynamically loading the module. Accessibility software needs to detect the live regions in order to announce them. The `@wordpress/a11y` script module was adding the live regions to the DOM correctly when the module was loaded, but when loaded dynamically (via `import( '@wordpress/a11y' ).then( /*…*/ )` ) the live region changes would happen before the live region was detected by accessibility software and the announcements would not happen. The `@wordpress/a11y` script module is updated so that it does not inject the live regions into the DOM but expects them to be present on the page. A hook is added to inject the necessary HTML for the live regions when the @wordpress/a11y script module may be present (enqueued or in the import map). This has a few additional advantages: - Accessibility software correctly detects the live regions. - The DOM does not need to be modified immediately on page load. - The (gzipped) size of the script module is reduced by 416B (~46%). The `wp-a11y` script shares the same DOM elements. It includes protection to prevent injecting duplicate elements. --- Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org>
…63908) * Use real labels instaed of headings or aria-labels. * Simplify by removing RangeControl. * Remove unnecessary HStack and className. * Remove no longer used hasNegativeRange prop. Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: joedolson <joedolson@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
…ss#65362) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
…me are enabled (WordPress#65372)" (WordPress#65402) This reverts commit 99fefd7. Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
…4961) * Docs: minor changes under Prerequisites in Build first block tutorial * Docs: fix minor typos in Build first block tutorial
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: keoshi <keoshi@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
Fix an issue where accessibility texts were always "" (empty string) in the Interactivity Router. Use the new `@wordpress/a11y` script module for accessibility in the Interactivity Router. The change to use the new script module is behind a Gutenberg-only feature flag. Pass static localization texts via script module data passing instead of through the Interactivity API store. --- Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: michalczaplinski <czapla@git.wordpress.org>
* Icons: Adds bell and bell-unread icons and updates the CHANGELOG file --------- Co-authored-by: javierarce <javiarce@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
* Move `proxifyContext` to proxies folder * Move context handlers outside * Remove unused code * Update comment * Add TODO comment * Remove unused code and rename `k` arg to `key` * Replace `updateContext` with `deepMerge` * Throw when calling `proxifyContext` on a context proxy * Add unit tests * Update changelog * Added new tests to validate behavior with proxified state. Also included more descriptive error messages for re-proxification attempts. --------- Co-authored-by: DAreRodz <darerodz@git.wordpress.org> Co-authored-by: michalczaplinski <czapla@git.wordpress.org> Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
Unlinked contributors: smerriman, ericdye, laurelfulford. Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: lgladdy <lgladdy@git.wordpress.org> Co-authored-by: MadtownLems <madtownlems@git.wordpress.org>
…ress#65590) * Revert "Font Library: Group fonts by source (WordPress#63211)" * update typography screen description * update screen description Co-authored-by: vcanales <vcanales@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org>
* updates LayoutTypeSwitcher to useToggleGroupControl * updates label and corrects LayoutTypeSwitcher component misconfiguration Co-authored-by: spadeshoe <spdft@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
* Navigation block: Use apply-block-hooks-to-content * WPCS Co-authored-by: ockham <bernhard-reiter@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
* Categories block: Escape label Escape the label attribute before output inside the label HTML element, using esc_html(). * Categories: Switch escaping function Escape the label with wp_kses_post() instead of esc_html to allow some HTML tags and to be consistent with escaping other labels in other blocks. Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
This commit creates a static category map based on list defined in Style Book: Iterate on presentation and design. WordPress#53431. It also: - Sorts examples based on static categories and their subcategories - Introduces simple layout for subcategories (under theme) - Adds unit tests for utils - Converts utils to TypeScript Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: vcanales <vcanales@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
…c. (WordPress#65715) * Fix in Dataforms layouts * Fix in Patterns header * Fix in Patterns import popover * Fix in nux * Fix in ReusableBlockConvertButton * Update snapshot Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
…5734) Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
…Registry. (WordPress#65710) * Try use select and dispatch instead of registry * Pass `select` to `canUserEditValue` * Pass `select` to `getFieldsList` * Fix `setValues` --------- Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org> Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
* ToggleGroupControl: Fix arrow key navigation in RTL * Add changelog Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
* Tweak sizing and overflow behavior of TabList. * Add size and overflow playground story. * Add "scroll into view" behavior to selected tabs. * fit-content only on horizontal orientation * Reduce specificity of `fit-content` to make it easier to override. * centered label only when orientation is horizontal * Remove unused file. * Fix inspector controls tabs. * Fix font library modal tabs. * Fix style-book tabs. * fix typo * Add changelog entry. * fix emotion being weird ugh * Prevent unwanted focusable container in Firefox. * Add fade effect. * Fix IntersectionObserver logic. * Feature detect IntersectionObserver to prevent tests from failing. * Add a bit of tolerance for scroll state detection. * Fix vertical indicator. * Better handling of vertical overflow. * Add a bit of scroll margin for better "scroll into view" experience. * Horizontal fade should only happen on horizontal direction. * Adjust for offset parent scroll state in `getElementOffsetRect`. * Better "scroll into view" positioning heuristics ("nearest"). * Invert use of before and after to remove z-index and fix related issues. * Make vertical indicator light blue as discussed. * Undo most overrides in pattern/media vertical tabs. * Clean up outdated styles previously needed for label wrapping. * Revert vertical indicator changes and some indicator patterns/media tabs styles * Revert vertical indicator bug fix * Add changelog entry * Remove outdated style. * Address feedback * Fix scroll bug * Improve automatic tab scrolling behavior. * Tweaks to prevent unit test failure and minor cleanup. * Undo unnecessary changes. * Improved story * Fix scroll jumping bug. * Scroll to active tab instead of selected (support `selectOnMove=false`). * Fix minor visual glitch with overflow fade out indicators. * Misc tweaks * Fix. * Fix changelog * Fix changelog but it's actually true * Fix changelog * Make Story Book tabs nicer. * Temp fix for scrollbar issue in Style Book tabs. * Fix scroll bug and clean up a little. * Simplify and clean up a bit more. * Fix merge issues. * Fix merge issues again. * Make inserter patterns/media changes more minimal * Fix outdated comment * Fix another typo in comment. * Minor cleanup. * Fix bad automatic merge. * ugh, fix again Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org>
* Update tools menus: - Write / Design order - Change description copy * update tools help text --------- Co-authored-by: mtias <matveb@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: provenself <provenself@git.wordpress.org>
Removes code related to showing/hiding inserters on hover.
* Try use select and dispatch instead of registry * Fix `setValues` * Open `useBlockBindingsUtils` * Open registration APIs * Restrict `getFieldsList` API * Update `useBlockBindingsUtils` docs * Update register/unregister bindings docs * Simplify API functions examples Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl> * Update docs * Update comments --------- Co-authored-by: Carlos Bravo <37012961+cbravobernal@users.noreply.github.com> Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl> Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org> Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
* List view: fix miscolored icons * Add forced-colors media query Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
* Update block-filters.md Added description for `blocks.getBlockAttributes` filter * Modified example and provided additional info * modified example and provided additional info Explained the parameters accepted by the filter callback function. * modified example and provided additional info Fixed parameter names. * Update docs/reference-guides/filters/block-filters.md Thanks Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md Thanks for the suggestion. Not aware of the format since it's my first time. Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> --------- Co-authored-by: davy440 <indithemes@git.wordpress.org> Co-authored-by: akasunil <sunil25393@git.wordpress.org>
Co-authored-by: draganescu <andraganescu@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: ajlende <ajlende@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
* Fix in Skip to selected block * Fix in Tool selector * Fix in URLInputButton * Fix in URLInput * Remove dead code in FlexLayoutVerticalAlignmentControl Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @gutenbergplugin. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
bf20345
into
poojabhimani12:try/inline-block-commenting
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast