Openverse: prevent multiple insertions during upload #65719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +28 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c07f8ce. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11086310859
|
youknowriad
reviewed
Sep 30, 2024
packages/block-editor/src/components/inserter/media-tab/media-preview.js
Outdated
Show resolved
Hide resolved
Actually I'm not sure this is true. Isn't that different from the behavior of the inserter for blocks and patterns. Personally I expect a new block to be inserted each time I click on the media. Maybe we can save a cache of media elements per external image if needed but I'm not sure we should be changing how the inserter works. |
No, this is not what this PR is about... Let me try to explain differently. When using Media Experiments, the issue is this:
Of course, every time I click on the media, a new upload process should be triggered and a new block should be added. But then this block should only be added once per click, not numerous times. Hope that makes sense. If not, just install Media Experiments and try it yourself. Happy to provide a screencast otherwise... |
|
Yes, it does, thanks for explaining. Let me test this a bit. |
|
In my tests in this PR, If I click again on an image after I had added it to the post, it doesn't insert it again. Am I missing something? |
Well then this unintentional, and probably is because of #65719 (comment) where I didn't reset the ref. |
|
I just removed the ref now in favor of simply using |
youknowriad
reviewed
Sep 30, 2024
packages/block-editor/src/components/inserter/media-tab/media-preview.js
Outdated
Show resolved
Hide resolved
youknowriad
approved these changes
Sep 30, 2024
Yeah right now it's only with the Media Experiments plugin, but eventually also with the client-side media processing experiment flag in Gutenberg (once that is merged) |
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
Co-authored-by: swissspidy <swissspidy@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When adding an Openverse image from the inserter,
mediaUpload()is called to upload the image to the media library.Inserting the block onto the canvas happens in the
onFileChangecallback.This callback can theoretically be called multiple times, especially in the future.
The block should only be inserted once though, and on subsequent invocations it should just update the existing block.
Why?
I noticed this while working on client-side media processing, see swissspidy/media-experiments#693 and #61447
There, the
onFileChangecallback can be fired dozens of times, which caused the block to be inserted over and over again.How?
Uses a
refto check whether the block has already been inserted or not.Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast