Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectControl: Add story for prefix slot #65730

Merged
merged 1 commit into from
Sep 30, 2024
Merged

SelectControl: Add story for prefix slot #65730

merged 1 commit into from
Sep 30, 2024

Conversation

mirka
Copy link
Member

@mirka mirka commented Sep 30, 2024

What?

Adds a SelectControl story to highlight the prefix slot usage.

Testing Instructions

See the "With Prefix" story for SelectControl.

Screenshots or screencast

SelectControl with prefix story

@mirka mirka added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components Storybook Storybook and its stories for components labels Sep 30, 2024
@mirka mirka self-assigned this Sep 30, 2024
@mirka mirka requested a review from ajitbohra as a code owner September 30, 2024 08:19
mirka
mirka commented Sep 30, 2024
View reviewed changes
packages/components/src/select-control/stories/index.story.tsx
@@ -64,6 +65,7 @@ const SelectControlWithState: StoryFn< typeof SelectControl > = ( props ) => {
export const Default = SelectControlWithState.bind( {} );
Default.args = {
__nextHasNoMarginBottom: true,
label: 'Label',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here — I noticed that we don't add labels in our stories, which is bad for accessibility. Let's add them.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mirka mirka requested a review from a team September 30, 2024 08:21
@github-actions GitHub Actions
Copy link

Flaky tests detected in 7451b9d.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11102187879
📝 Reported issues:

tyxla
tyxla approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks 🚀

@mirka mirka merged commit 5e47d48 into trunk Sep 30, 2024
71 of 72 checks passed
@mirka mirka deleted the select-control-prefix-story branch September 30, 2024 09:17
@github-actions github-actions bot added this to the Gutenberg 19.4 milestone Sep 30, 2024
huubl pushed a commit to huubl/gutenberg that referenced this pull request Oct 2, 2024
@mirka @tyxla @huubl
SelectControl: Add story for prefix slot (WordPress#65730)
de28b06 
Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
huubl added a commit to huubl/gutenberg that referenced this pull request Oct 2, 2024
@huubl
Revert "SelectControl: Add story for prefix slot (WordPress#65730)"
6526c82 
This reverts commit de28b06.
@mirka mirka mentioned this pull request Nov 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@mirka mirka

Labels
[Package] Components /packages/components Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 19.4
Development

Successfully merging this pull request may close these issues.
2 participants
@mirka @tyxla