List view: fix miscolored icons #65707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -129 B (-0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Is there a need to include other styles specified for button > svg? gutenberg/packages/components/src/button/style.scss Lines 374 to 380 in 3155ab7 |
No, I don't think so. One of the instances where the |
While the |
|
Thank you everyone for your reviews. I only added the Below is a comparison of how it looks in the Edge browser with contrast mode called "Night" Sky and color forcing enabled:
The screen with the In the future, we might be able to convert the |
|
Thank you! I think we can merge this PR in its current state :) |
getdave
pushed a commit
that referenced
this pull request
Oct 1, 2024
* List view: fix miscolored icons * Add forced-colors media query Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
* List view: fix miscolored icons * Add forced-colors media query Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
huubl
added a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
This reverts commit a5d48bc.
draganescu
pushed a commit
that referenced
this pull request
Oct 2, 2024
* List view: fix miscolored icons * Add forced-colors media query Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
|
@t-hamano In the Should this PR be backported? |
t-hamano
added
the
Backport to WP 6.7 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 12, 2024
* List view: fix miscolored icons * Add forced-colors media query Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: e37cd2c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65697
What?
This PR fixes the icon color inconsistency (chevron, sticky, lock) in the List view.
Why?
As of #65361, the list view button has been replaced with the
aelement instead of theButtoncomponent. This means that the following styles no longer apply:gutenberg/packages/components/src/button/style.scss
Line 373 in 3155ab7
How?
Considering the possibility that new icons may be added to list view buttons in the future, I added
fill:currentColorto all SVGs in the list view buttons. This selector should be equivalent to the previous.components-button svg.Testing Instructions
Screenshots or screencast