Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vanilla): bail out recomputing with the same value #2016

Merged
merged 5 commits into from
Jul 5, 2023
Merged

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jul 4, 2023

Related Issues or Discussions

Fixes #2014

Summary

It's a regression from v1. It now checks atom values.

Check List

  • yarn run prettier for formatting code and docs

@vercel
Copy link

vercel bot commented Jul 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 9:51am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit efe2a7b:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration
atomState.d changes Issue #2014

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Size Change: +107 B (0%)

Total Size: 67.3 kB

Filename Size Change
dist/system/vanilla.development.js 3.81 kB +49 B (+1%)
dist/system/vanilla.production.js 1.92 kB +10 B (+1%)
dist/umd/vanilla.development.js 4.57 kB +18 B (0%)
dist/umd/vanilla.production.js 2.12 kB +15 B (+1%)
dist/vanilla.js 4.47 kB +15 B (0%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 916 B
dist/babel/plugin-react-refresh.js 1.15 kB
dist/babel/preset.js 1.39 kB
dist/index.js 229 B
dist/react.js 1.05 kB
dist/react/utils.js 1.26 kB
dist/system/babel/plugin-debug-label.development.js 1.09 kB
dist/system/babel/plugin-debug-label.production.js 764 B
dist/system/babel/plugin-react-refresh.development.js 1.29 kB
dist/system/babel/plugin-react-refresh.production.js 935 B
dist/system/babel/preset.development.js 1.57 kB
dist/system/babel/preset.production.js 1.14 kB
dist/system/index.development.js 236 B
dist/system/index.production.js 167 B
dist/system/react.development.js 1.17 kB
dist/system/react.production.js 701 B
dist/system/react/utils.development.js 713 B
dist/system/react/utils.production.js 451 B
dist/system/utils.development.js 241 B
dist/system/utils.production.js 175 B
dist/system/vanilla/utils.development.js 4.48 kB
dist/system/vanilla/utils.production.js 2.74 kB
dist/umd/babel/plugin-debug-label.development.js 1.07 kB
dist/umd/babel/plugin-debug-label.production.js 850 B
dist/umd/babel/plugin-react-refresh.development.js 1.29 kB
dist/umd/babel/plugin-react-refresh.production.js 1.02 kB
dist/umd/babel/preset.development.js 1.53 kB
dist/umd/babel/preset.production.js 1.25 kB
dist/umd/index.development.js 371 B
dist/umd/index.production.js 321 B
dist/umd/react.development.js 1.18 kB
dist/umd/react.production.js 785 B
dist/umd/react/utils.development.js 1.42 kB
dist/umd/react/utils.production.js 1.03 kB
dist/umd/utils.development.js 386 B
dist/umd/utils.production.js 334 B
dist/umd/vanilla/utils.development.js 5.2 kB
dist/umd/vanilla/utils.production.js 3.21 kB
dist/utils.js 236 B
dist/vanilla/utils.js 5.07 kB

compressed-size-action

@dai-shi dai-shi added this to the v2.2.2 milestone Jul 5, 2023
@dai-shi dai-shi merged commit 85cccb1 into main Jul 5, 2023
@dai-shi dai-shi deleted the fix/issue-2014 branch July 5, 2023 13:38
davydkov referenced this pull request in likec4/likec4 Jul 21, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [jotai](https://togithub.com/pmndrs/jotai) | [`^2.2.1` ->
`^2.2.2`](https://renovatebot.com/diffs/npm/jotai/2.2.1/2.2.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/jotai/2.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/jotai/2.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/jotai/2.2.1/2.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/jotai/2.2.1/2.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pmndrs/jotai (jotai)</summary>

### [`v2.2.2`](https://togithub.com/pmndrs/jotai/releases/tag/v2.2.2)

[Compare
Source](https://togithub.com/pmndrs/jotai/compare/v2.2.1...v2.2.2)

This includes some fixes for edge cases.

#### What's Changed

- fix(vanilla): bail out recomputing with the same value by
[@&#8203;dai-shi](https://togithub.com/dai-shi) in
[https://github.com/pmndrs/jotai/pull/2016](https://togithub.com/pmndrs/jotai/pull/2016)
- fix(utils): loadable handles sync errors by
[@&#8203;dai-shi](https://togithub.com/dai-shi) in
[https://github.com/pmndrs/jotai/pull/2021](https://togithub.com/pmndrs/jotai/pull/2021)

#### New Contributors

- [@&#8203;vossmalte](https://togithub.com/vossmalte) made their first
contribution in
[https://github.com/pmndrs/jotai/pull/2006](https://togithub.com/pmndrs/jotai/pull/2006)

**Full Changelog**:
pmndrs/jotai@v2.2.1...v2.2.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/likec4/likec4).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDQuMiIsInVwZGF0ZWRJblZlciI6IjM2LjguMTEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atoms sometimes cause updates to dependencies even when their value remains the same
1 participant