Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vanilla): bail out recomputing with the same value #2016

Merged
merged 5 commits into from
Jul 5, 2023
Merged

fix(vanilla): bail out recomputing with the same value #2016

merged 5 commits into from
Jul 5, 2023

Commits on Jul 4, 2023

  1. add a failing test

    @dai-shi
    dai-shi committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    9da0d6a View commit details
    Browse the repository at this point in the history

  2. a fix, is it hacky?

    @dai-shi
    dai-shi committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    0f1f957 View commit details
    Browse the repository at this point in the history

  3. refactor: simplify logic

    @dai-shi
    dai-shi committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    3348af0 View commit details
    Browse the repository at this point in the history

  4. drop a test without sub, which may break in the future.

    @dai-shi
    dai-shi committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    da07d9f View commit details
    Browse the repository at this point in the history

  5. fix with a hack

    @dai-shi
    dai-shi committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    efe2a7b View commit details
    Browse the repository at this point in the history