refactor(vanilla): simplify store impl #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 89a9527:
|
|
Size Change: -64 B (0%) Total Size: 67.9 kB
ℹ️ View Unchanged
|
dai-shi
commented
Jul 31, 2023
Comment on lines
+373
to
377
| Array.from(atomState.d).every( | ||
| ([a, s]) => a === atom || readAtomState(a) === s | ||
| ) | ||
| ) { | ||
| return atomState |
There was a problem hiding this comment.
I hope to remove this for #1901, but this breaks various behavior including async atoms on mount. Hope to revisit it in the far future.
| mountedMap.set(atom, mounted) | ||
| if (import.meta.env?.MODE !== 'production') { | ||
| mountedAtoms.add(atom) | ||
| } |
There was a problem hiding this comment.
It feels like our mountAtom has room for improvement (like propagating changed from dependencies).
It might be related with the previous comment, but not sure.
This was referenced Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the hack in #2016.
As we update state wisely in #1956, we should be able to skip things.Hopefully, this will improve the issue in #1901.