Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atomWithStorage issue since 2.3.0+ #2098

Closed
dai-shi opened this issue Aug 28, 2023 Discussed in #2095 · 3 comments · Fixed by #2099
Closed

atomWithStorage issue since 2.3.0+ #2098

dai-shi opened this issue Aug 28, 2023 Discussed in #2095 · 3 comments · Fixed by #2099
Labels
bug Something isn't working help wanted Please someone help on this

Comments

@dai-shi
Copy link
Member

dai-shi commented Aug 28, 2023 •
edited
Loading

This is a tracking issue for #2095. See discussions there.

Reproduction: https://codesandbox.io/s/sharp-lamport-k9s8mp?file=/src/App.tsx

I think it's a bug in #2029 and it's not specific to atomWithStorage.

Tasks:

  1. Create a failing test (without atomWithStorage, hopefully only with store api)
  2. Fix it
@dai-shi dai-shi added bug Something isn't working help wanted Please someone help on this labels Aug 28, 2023
@dai-shi
Copy link
Member Author

dai-shi commented Aug 28, 2023

Would anyone like to work on Task 1?

@gerzonc
Copy link
Contributor

gerzonc commented Aug 28, 2023

Would anyone like to work on Task 1?

Would like to get into it if it's okay :)

@dai-shi
Copy link
Member Author

dai-shi commented Aug 28, 2023

Sure!

@tmkx tmkx mentioned this issue Aug 29, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Please someone help on this
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(vanilla): should recompute state after onMount
2 participants
@dai-shi @gerzonc