fix(vanilla): bail out recomputing with the same value (#2016)

* add a failing test

* a fix, is it hacky?

* refactor: simplify logic

* drop a test without sub, which may break in the future.

* fix with a hack

src/vanilla/store.ts

@@ -373,9 +373,17 @@ export const createStore = () => {
       // If a dependency changed since this atom was last computed,
       // then we're out of date and need to recompute.
       if (
-        Array.from(atomState.d).every(
-          ([a, s]) => a === atom || getAtomState(a) === s
-        )
+        Array.from(atomState.d).every(([a, s]) => {
+          const aState = getAtomState(a)
+          return (
+            a === atom ||
+            aState === s ||
+            // TODO This is a hack, we should find a better solution.
+            (aState &&
+              !hasPromiseAtomValue(aState) &&
+              isEqualAtomValue(aState, s))
+          )
+        })
       ) {
         return atomState
       }

tests/vanilla/store.test.tsx

@@ -348,3 +348,27 @@ it('should notify subscription with tree dependencies with bail-out', async () =
   expect(cb).toBeCalledTimes(1)
   expect(store.get(dep3Atom)).toBe(4)
 })
+
+it('should bail out with the same value with chained dependency (#2014)', async () => {
+  const store = createStore()
+  const objAtom = atom({ count: 1 })
+  const countAtom = atom((get) => get(objAtom).count)
+  const deriveFn = vi.fn((get: Getter) => get(countAtom))
+  const derivedAtom = atom(deriveFn)
+  const deriveFurtherFn = vi.fn((get: Getter) => {
+    get(objAtom) // intentional extra dependency
+    return get(derivedAtom)
+  })
+  const derivedFurtherAtom = atom(deriveFurtherFn)
+  const callback = vi.fn()
+  store.sub(derivedFurtherAtom, callback)
+  expect(store.get(derivedAtom)).toBe(1)
+  expect(store.get(derivedFurtherAtom)).toBe(1)
+  expect(callback).toHaveBeenCalledTimes(0)
+  expect(deriveFn).toHaveBeenCalledTimes(1)
+  expect(deriveFurtherFn).toHaveBeenCalledTimes(1)
+  store.set(objAtom, (obj) => ({ ...obj }))
+  expect(callback).toHaveBeenCalledTimes(0)
+  expect(deriveFn).toHaveBeenCalledTimes(1)
+  expect(deriveFurtherFn).toHaveBeenCalledTimes(2)
+})