Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use net.JoinHostPort to generate host-port part of URI #6249

Closed
D3Hunter opened this issue Jul 11, 2022 · 1 comment · Fixed by #6248
Closed

use net.JoinHostPort to generate host-port part of URI #6249

D3Hunter opened this issue Jul 11, 2022 · 1 comment · Fixed by #6248
Labels
affects-5.3 affects-5.4 affects-6.1 area/dm Issues or PRs related to DM. severity/minor type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

D3Hunter commented Jul 11, 2022 •
edited
Loading

Is your feature request related to a problem?

NA

Describe the feature you'd like

to use ipv6 address, dm can workaround by add square brackets explicitly, but if the task use lightning as loader(since 6.0), this workaround won't work since lightning will use net.JoinHostPort to generate uri after pingcap/tidb#35881.

so dm should unifies how we generate host-port part of db uri to net.JoinHostPort too

see #6135 too

Describe alternatives you've considered

No response

Teachability, Documentation, Adoption, Migration Strategy

No response
@D3Hunter D3Hunter added type/enhancement The issue or PR belongs to an enhancement. area/dm Issues or PRs related to DM. labels Jul 11, 2022
@D3Hunter D3Hunter mentioned this issue Jul 11, 2022
Merged
1 task
@D3Hunter D3Hunter added type/bug The issue is confirmed as a bug. and removed type/enhancement The issue or PR belongs to an enhancement. labels Jul 11, 2022
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jul 11, 2022 •
edited
Loading

it's ok to take it as an enhancement or bug.

@D3Hunter D3Hunter mentioned this issue Jul 12, 2022
Closed
ti-chi-bot pushed a commit that referenced this issue Jul 19, 2022
@D3Hunter
db(dm): use net.JoinHostPort to generate host-port part of URI (#6248)
b4bbb86 
close #6249
This was referenced Jul 19, 2022
Merged
Merged
Merged
ti-chi-bot added a commit that referenced this issue Jul 27, 2022
@ti-chi-bot
db(dm): use net.JoinHostPort to generate host-port part of URI (#6248…
e6ae88f 
…) (#6341)

close #6249
ti-chi-bot added a commit that referenced this issue Jul 28, 2022
@ti-chi-bot
db(dm): use net.JoinHostPort to generate host-port part of URI (#6248…
4834ae0 
…) (#6342)

close #6249
ti-chi-bot added a commit that referenced this issue Jul 28, 2022
@ti-chi-bot
db(dm): use net.JoinHostPort to generate host-port part of URI (#6248…
bcd3c7e 
…) (#6343)

close #6249
This was referenced Aug 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.3 affects-5.4 affects-6.1 area/dm Issues or PRs related to DM. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

db(dm): use net.JoinHostPort to generate host-port part of URI buchuitoudegou/tiflow
1 participant
@D3Hunter