-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
db(dm): use net.JoinHostPort
to generate host-port part of URI (#6248)
#6341
db(dm): use net.JoinHostPort
to generate host-port part of URI (#6248)
#6341
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @lance6716 @buchuitoudegou plz review again, since this cp changes less code ipv6 addr tested manually |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ba43572
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 08703ba
|
/run-leak-test |
This is an automated cherry-pick of #6248
What problem does this PR solve?
Issue Number: close #6249
What is changed and how it works?
unifies how we generate host-port part of db uri to
net.JoinHostPort
. we need to update dumpling(tidb repo) and go-mysql to make dm work correctly for ipv6.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note