Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db(dm): use net.JoinHostPort to generate host-port part of URI #6248

Merged
merged 17 commits into from
Jul 19, 2022
Merged

db(dm): use net.JoinHostPort to generate host-port part of URI #6248

merged 17 commits into from
Jul 19, 2022

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Jul 11, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #6249

What is changed and how it works?

unifies how we generate host-port part of db uri to net.JoinHostPort. we need to update dumpling(tidb repo) and go-mysql to make dm work correctly for ipv6.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • since CI doesn't support ipv6, test locally to use ipv6 addr for upstream & downstream
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

use `net.JoinHostPort` to generate host-port part of URI to support ipv6 address.

@D3Hunter D3Hunter added the area/dm Issues or PRs related to DM. label Jul 11, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • buchuitoudegou
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2022
@D3Hunter D3Hunter added needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. and removed needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Jul 11, 2022
@D3Hunter
Copy link
Contributor Author

/run-dm-integration-test

2 similar comments
@D3Hunter
Copy link
Contributor Author

/run-dm-integration-test

@D3Hunter
Copy link
Contributor Author

/run-dm-integration-test

@D3Hunter D3Hunter marked this pull request as ready for review July 11, 2022 11:59
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2022
@D3Hunter
Copy link
Contributor Author

/cc @lance6716 @buchuitoudegou

@D3Hunter D3Hunter added needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Jul 11, 2022
@D3Hunter
Copy link
Contributor Author

/run-all-tests

1 similar comment
@D3Hunter
Copy link
Contributor Author

/run-all-tests

@lance6716
Copy link
Contributor 

dial tcp [::1]:3306: connect: network is unreachable

our CI doesn't support ipv6, we can only test it in our own PC

lance6716
lance6716 previously approved these changes Jul 12, 2022
View reviewed changes
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2022
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2022
@D3Hunter
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2022
@D3Hunter
Copy link
Contributor Author

/run-all-tests

@D3Hunter
Copy link
Contributor Author

/run-all-tests

@D3Hunter
Copy link
Contributor Author

/run-dm-integration-test

@D3Hunter
Copy link
Contributor Author

/run-all-tests

@D3Hunter
Copy link
Contributor Author

@lance6716 ptal

@D3Hunter
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9a7c1cd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 19, 2022
@D3Hunter
Copy link
Contributor Author

/run-verify

@ti-chi-bot ti-chi-bot merged commit b4bbb86 into pingcap:master Jul 19, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 19, 2022
@D3Hunter @ti-chi-bot
This is an automated cherry-pick of pingcap#6248
d1ec6f9 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 19, 2022
Merged
1 task
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6341.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 19, 2022
@D3Hunter @ti-chi-bot
This is an automated cherry-pick of pingcap#6248
aa28418 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 19, 2022
Merged
1 task
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6342.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 19, 2022
@D3Hunter @ti-chi-bot
This is an automated cherry-pick of pingcap#6248
cdc9a02 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 19, 2022
Merged
1 task
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6343.

@D3Hunter D3Hunter deleted the fix-ipv6-addr branch July 19, 2022 06:56
ti-chi-bot added a commit that referenced this pull request Jul 27, 2022
@ti-chi-bot
db(dm): use net.JoinHostPort to generate host-port part of URI (#6248…
e6ae88f 
…) (#6341)

close #6249
ti-chi-bot added a commit that referenced this pull request Jul 28, 2022
@ti-chi-bot
db(dm): use net.JoinHostPort to generate host-port part of URI (#6248…
4834ae0 
…) (#6342)

close #6249
ti-chi-bot added a commit that referenced this pull request Jul 28, 2022
@ti-chi-bot
db(dm): use net.JoinHostPort to generate host-port part of URI (#6248…
bcd3c7e 
…) (#6343)

close #6249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buchuitoudegou buchuitoudegou buchuitoudegou approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use net.JoinHostPort to generate host-port part of URI
6 participants
@D3Hunter @ti-chi-bot @lance6716 @codecov-commenter @asddongmen @buchuitoudegou