TiCDC mysql sink can not connect to ipv6 address

[overvenus]

What did you do?

Create a changefeed that replicate data to an ipv6 address MySQL server.

tiup cdc cli changefeed create --pd="http://[::1]:2379" --sink-uri="tidb://root:@[::1]:4005/" --changefeed-id="simple-replication-task" --sort-engine="unified" 

tiflow/cdc/sink/mysql/mysql.go

Line 109 in ee4e36c

dsnStr := fmt.Sprintf("%s:%s@tcp(%s:%s)/%s", username, password, hostName, port, params.tls)

We should use net.JoinHostPort for hostnames that are in literal IP addresses.

Workaround: use DNS domain name.

What did you expect to see?

Success.

What did you see instead?

Starting component cdc: /Users/.tiup/components/cdc/v6.1.0/cdc cli changefeed create --pd=http://[::1]:2379 --sink-uri=tidb://root:@[::1]:4005/ --changefeed-id=simple-replication-task --sort-engine=unified
Error: [CDC:ErrMySQLConnectionError]fail to open MySQL connection: dial tcp [::1:4005]:3306: connect: no route to host

Versions of the cluster

TiCDC version (execute cdc version):

v6.1.0

[lance6716]

please also consider fixing DM's usage

tiflow/dm/pkg/conn/basedb.go

Line 62 in ee4e36c

dsn := fmt.Sprintf("%s:%s@tcp(%s:%d)/?charset=utf8mb4&interpolateParams=true&maxAllowedPacket=0",

[3pointer]

sync-diff & tidb-binlog may also have the problem.
https://github.com/pingcap/tidb-tools/blob/b3ea358e374a64f19258dc21d880e7ec07342366/pkg/dbutil/common.go#L118

[Rustin170506]

please also consider fixing DM's usage

tiflow/dm/pkg/conn/basedb.go

Line 62 in ee4e36c

dsn := fmt.Sprintf("%s:%s@tcp(%s:%d)/?charset=utf8mb4&interpolateParams=true&maxAllowedPacket=0",

The problem with dm might be that the user might pass ::1 instead of [::1], right?

[lance6716]

please also consider fixing DM's usage

tiflow/dm/pkg/conn/basedb.go

Line 62 in ee4e36c

dsn := fmt.Sprintf("%s:%s@tcp(%s:%d)/?charset=utf8mb4&interpolateParams=true&maxAllowedPacket=0",

The problem with dm might be that the user might pass ::1 instead of [::1], right?

Maybe DM should support both type, I haven't take a look at IPv6 address format 😂

[Rustin170506]

please also consider fixing DM's usage

tiflow/dm/pkg/conn/basedb.go

Line 62 in ee4e36c

dsn := fmt.Sprintf("%s:%s@tcp(%s:%d)/?charset=utf8mb4&interpolateParams=true&maxAllowedPacket=0",

The problem with dm might be that the user might pass ::1 instead of [::1], right?

Maybe DM should support both type, I haven't take a look at IPv6 address format 😂

::1 is not a valid address in DSN, but [::1] is.

[nongfushanquan]

/label affect-6.1

[ti-chi-bot]

@nongfushanquan: The label(s) affect-6.1 cannot be applied. These labels are supported: duplicate, bug-from-internal-test, bug-from-user, affects-4.0, affects-5.0, affects-5.1, affects-5.2, affects-5.3, affects-5.4, affects-6.0, affects-6.1, may-affects-4.0, may-affects-5.0, may-affects-5.1, may-affects-5.2, may-affects-5.3, may-affects-5.4, may-affects-6.0, may-affects-6.1, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0, needs-cherry-pick-release-5.1, needs-cherry-pick-release-5.2, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.0, needs-cherry-pick-release-6.1, question, release-blocker, wontfix, require-LGT1, require-LGT3.

In response to this:

/label affect-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[nongfushanquan]

/label affects-6.1

[D3Hunter]

please also consider fixing DM's usage

tiflow/dm/pkg/conn/basedb.go

Line 62 in ee4e36c

dsn := fmt.Sprintf("%s:%s@tcp(%s:%d)/?charset=utf8mb4&interpolateParams=true&maxAllowedPacket=0",

The problem with dm might be that the user might pass ::1 instead of [::1], right?

Maybe DM should support both type, I haven't take a look at IPv6 address format 😂

::1 is not a valid address in DSN, but [::1] is.

square brackets are not part of the address, it part of the URI syntax. IPV6 address doesn't has square brackets.

A host identified by an Internet Protocol literal address, version 6
[RFC3513] or later, is distinguished by enclosing the IP literal
within square brackets ("[" and "]").

see https://www.rfc-editor.org/rfc/rfc3986#section-3.2.2

[Rustin170506]

square brackets are not part of the address, it part of the URI syntax. IPV6 address doesn't has square brackets.

Uh-huh, That's what I meant too.