ddl, meta: allow increasing auto_random bits #17423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17423 +/- ##
================================================
- Coverage 79.7675% 79.4591% -0.3085%
================================================
Files 525 524 -1
Lines 144184 141362 -2822
================================================
- Hits 115012 112325 -2687
+ Misses 19993 19958 -35
+ Partials 9179 9079 -100 |
djshow832
reviewed
May 27, 2020
bb7133
reviewed
Jun 4, 2020
zimulala
reviewed
Jun 5, 2020
| @@ -585,17 +588,20 @@ func (w *worker) onModifyColumn(t *meta.Meta, job *model.Job) (ver int64, _ erro | |||
| oldColName := &model.CIStr{} | |||
| pos := &ast.ColumnPosition{} | |||
| var modifyColumnTp byte | |||
| err := job.DecodeArgs(newCol, oldColName, pos, &modifyColumnTp) | |||
| var updatedAutoRandomBits uint64 | |||
| err := job.DecodeArgs(newCol, oldColName, pos, &modifyColumnTp, &updatedAutoRandomBits) | |||
There was a problem hiding this comment.
The DDL owner is an old-version TiDB: auto_random shard bits remain unchanged(but DDL successfully executed).
It will not cause data inconsistency, but it will confuse the user, the execution is successful, but the function is not successful.
zimulala
reviewed
Jun 5, 2020
| @@ -585,17 +588,20 @@ func (w *worker) onModifyColumn(t *meta.Meta, job *model.Job) (ver int64, _ erro | |||
| oldColName := &model.CIStr{} | |||
| pos := &ast.ColumnPosition{} | |||
| var modifyColumnTp byte | |||
| err := job.DecodeArgs(newCol, oldColName, pos, &modifyColumnTp) | |||
| var updatedAutoRandomBits uint64 | |||
| err := job.DecodeArgs(newCol, oldColName, pos, &modifyColumnTp, &updatedAutoRandomBits) | |||
There was a problem hiding this comment.
At the moment, I don’t seem to have any good methods other than the newly added types. Or you ask if the DBA can accept this situation
zimulala
reviewed
Jun 9, 2020
zimulala
added
the
compatibility-breaker
zimulala
added
status/LGT3
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@tangenta merge failed. |
|
/run-common-test |
tangenta
added a commit
to tangenta/tidb
that referenced
this pull request
Jul 14, 2020
tangenta
added a commit
to tangenta/tidb
that referenced
this pull request
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17422
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
ModifyColumn: newAutoRandBits.How it Works:
To make sure the new
auto_randombits number does not affect the correctness of implicit allocation, the check is as follows:If the length of the incremental bit in the new layout is greater than those in the origin layout, it is safe to switch to the new layout.
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note
auto_randombits is allowed to increase byALTER TABLEif possible.