Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl, meta: allow increasing auto_random bits (#17423) #18545

Conversation

tangenta
Copy link
Contributor

Cherry-pick #17423 to release-4.0.

Release note

  • The number of auto_random bits is allowed to increase by ALTER TABLE if possible.

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2020
@tangenta
Copy link
Contributor Author

/run-all-tests

@tangenta
Copy link
Contributor Author

/run-unit-test

FAIL: db_test.go:977: testDBSuite2.TestAddPrimaryKey2

db_test.go:978:
    testAddIndex(c, s.store, s.lease, true,
        `create table test_add_index (c1 bigint, c2 bigint, c3 bigint, key(c1))
    			      partition by range (c3) (
    			      partition p0 values less than (3440),
    			      partition p1 values less than (61440),
    			      partition p2 values less than (122880),
    			      partition p3 values less than (204800),
    			      partition p4 values less than maxvalue)`, "primary")
/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:190:
    tk.c.Assert(err, check.IsNil, check.Commentf("sql:%s, %v, error stack %v", sql, args, errors.ErrorStack(err)))
... value *errors.withStack = [domain:8027]Information schema is out of date: schema failed to update in 1 lease, please make sure TiDB can connect to TiKV ("[domain:8027]Information schema is out of date: schema failed to update in 1 lease, please make sure TiDB can connect to TiKV")

Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 15, 2020
@tangenta
Copy link
Contributor Author

/run-unit-test

TestT check-count 50 appears to have leaked

@bb7133
Copy link
Member

bb7133 commented Jul 15, 2020

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 18562

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@tangenta merge failed.

@tangenta
Copy link
Contributor Author

/run-integration-compatibility-test

level=warning msg="ping db failed

@tangenta tangenta closed this Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants