-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl, meta: allow increasing auto_random bits #17423
Merged
Merged
Changes from 6 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
2055362
ddl, meta: allow increasing auto_random bits
tangenta 82997c2
fix linter
tangenta 944b21e
Merge branch 'master' into autorand-increasing
AilinKid 09f694d
Merge branch 'master' into autorand-increasing
AilinKid 0bd0375
fix ci
tangenta efcc8b4
add comments about counting max shard bits
tangenta 609660b
prevent update meta key concurrently
tangenta d74b7b4
Merge remote-tracking branch 'upstream/master' into autorand-increasing
tangenta a989adf
sort import order
tangenta 69487c1
make fmt
tangenta eb37b3f
fix integration test
tangenta 28b399f
fix table name conflict in test
tangenta 7727609
Merge branch 'master' into autorand-increasing
bb7133 1df6f17
Merge branch 'master' into autorand-increasing
AilinKid 69f7512
autoid: polish auto_random error messages
tangenta 2b22027
Merge remote-tracking branch 'upstream/master' into autorand-increasing
tangenta 28da208
unistore: move coprocessor logic from unistore repo to tidb repo (#17…
coocood 8842281
unistore: move coprocessor analyze logic to tidb repo (#17661)
coocood e6d7b35
unistore: update unistore version to use tidb cophandler (#17666)
coocood f29026f
ddl: polish the comment in checkAutoRandom
tangenta 3a96e84
Merge remote-tracking branch 'upstream/master' into autorand-increasing
tangenta 41ba129
cancel job when it encounter error
tangenta 574c5c1
Merge remote-tracking branch 'upstream/master' into autorand-increasing
tangenta 69560cf
not to cancel the job when an error occurred
tangenta 6905f63
address comments
tangenta 1196ac4
address comments
tangenta 05556e2
address comment
tangenta 19ef062
Merge branch 'master' into autorand-increasing
tangenta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this DDL operation needs to be handled during the rolling upgrade, there may be compatibility issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If modifying
auto_random
bits is really necessary during updates, we need to consider two cases:auto_random
shard bits remain unchanged(but DDL successfully executed).I think none of them can lead to data inconsistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will not cause data inconsistency, but it will confuse the user, the execution is successful, but the function is not successful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I add job arguments to DDL jobs without affecting the rolling update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment, I don’t seem to have any good methods other than the newly added types. Or you ask if the DBA can accept this situation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, we can write this in the documents.