Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unistore: move coprocessor analyze logic to tidb repo #17661

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

coocood
Copy link
Member

@coocood coocood commented Jun 4, 2020

What problem does this PR solve?

Handle all unistore coprocessor request in tidb repo

What is changed and how it works?

  • copy analyze code.
  • change the exported function name to HandleCopRequest

Check List

Tests

  • Unit test

Release note

  • No release note

@coocood
Copy link
Member Author

coocood commented Jun 4, 2020

/run-all-tests

@coocood coocood requested review from lysu and bobotu June 4, 2020 05:52
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2020
@coocood
Copy link
Member Author

coocood commented Jun 4, 2020

/run-integration-copr-test

Copy link
Contributor

@bobotu bobotu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #17661 into master will decrease coverage by 0.0989%.
The diff coverage is 0.0000%.

@@               Coverage Diff                @@
##             master     #17661        +/-   ##
================================================
- Coverage   79.1012%   79.0022%   -0.0990%     
================================================
  Files           523        524         +1     
  Lines        140951     141001        +50     
================================================
- Hits         111494     111394       -100     
- Misses        20427      20588       +161     
+ Partials       9030       9019        -11     

@coocood coocood merged commit efc1c15 into pingcap:master Jun 4, 2020
@coocood coocood deleted the move-analyze branch June 4, 2020 05:59
tangenta pushed a commit to tangenta/tidb that referenced this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/unistore status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants