Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to GA the SET_VAR hint #45892

Closed
winoros opened this issue Aug 8, 2023 · 0 comments · Fixed by #45893
Closed

Add tests to GA the SET_VAR hint #45892

winoros opened this issue Aug 8, 2023 · 0 comments · Fixed by #45893
Labels
affects-7.5 sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.

Comments

@winoros
Copy link
Member

winoros commented Aug 8, 2023 •
edited
Loading

Enhancement

Make sure it can take effect as what we want

  • Test a bunch of variables that should take effect
  • If one variable is not tested, we will let SET_VAR change it and append a warning to tell the user that the hint might not take effect as expected at that time
@winoros winoros added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner labels Aug 8, 2023
@winoros winoros mentioned this issue Aug 8, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 8, 2023
@winoros
planner, variable: add test and ga the SET_VAR hint (#45893)
c6eb7bb 
close #45892
@winoros winoros mentioned this issue Sep 8, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 8, 2023
@winoros
sessionctx: add testcase for set_var hint (#46784)
968c712 
ref #45892
@winoros winoros mentioned this issue Sep 25, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 25, 2023
@winoros
planner: change SET_VAR behavior for non-verified vars and add some v…
7c1d60b 
…ar (#47258)

ref #45892
@shawn0915 shawn0915 mentioned this issue Oct 13, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 25, 2023
@shawn0915
sessionctx: fix var typo (#47609)
2a4f569 
ref #45892
@ti-chi-bot ti-chi-bot mentioned this issue Oct 25, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 25, 2023
@ti-chi-bot
sessionctx: fix var typo (#47609) (#47953)
2d87034 
ref #45892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.5 sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

planner, variable: add test and ga the SET_VAR hint winoros/tidb
2 participants
@winoros @ti-chi-bot