sessionctx: add testcase for set_var hint #46784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
crazycs520
approved these changes
Sep 8, 2023
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46784 +/- ##
================================================
- Coverage 73.3027% 72.7488% -0.5539%
================================================
Files 1322 1343 +21
Lines 396235 402992 +6757
================================================
+ Hits 290451 293172 +2721
- Misses 87261 91264 +4003
- Partials 18523 18556 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/approve |
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
crazycs520
approved these changes
Sep 8, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazycs520, easonn7, elsa0520 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #45892
Problem Summary:
What is changed and how it works?
We lost the case that SET_VAR is used after the session var has already changed to a value rather than the default one.
This time, we must restore it to the already changed value, not the default value.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.