-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sessionctx: fix var typo #47609
sessionctx: fix var typo #47609
Conversation
Welcome @shawn0915! |
Hi @shawn0915. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @shawn0915. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@winoros could you help take a look? |
/ok-to-test |
/test all |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47609 +/- ##
================================================
+ Coverage 71.9034% 74.1340% +2.2306%
================================================
Files 1396 1429 +33
Lines 405035 428854 +23819
================================================
+ Hits 291234 317927 +26693
+ Misses 94188 91603 -2585
+ Partials 19613 19324 -289
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test tiprow_fast_test |
@hawkingrei: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
be2a4d4
to
ef8f14f
Compare
@hawkingrei please confirm again, thank you. |
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, tiancaiamao, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test mysql-test |
@Defined2014: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test unit-test |
@Defined2014: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #45892
Problem Summary: fix typo
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.