Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: change SET_VAR behavior for non-verified vars and add some var #47258

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

winoros
Copy link
Member

@winoros winoros commented Sep 25, 2023

What problem does this PR solve?

Issue Number: ref #45892

Problem Summary:

What is changed and how it works?

For non-verified vars, we allow SET_VAR to change it.
Throw a warning to notify that the SET_VAR might not take effect since it's not verified.

And some more verified ones.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@winoros winoros requested a review from a team as a code owner September 25, 2023 12:18
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #47258 (dedf078) into master (3a1112b) will decrease coverage by 0.1221%.
Report is 10 commits behind head on master.
The diff coverage is 91.6666%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47258        +/-   ##
================================================
- Coverage   72.9411%   72.8190%   -0.1221%     
================================================
  Files          1340       1367        +27     
  Lines        400386     408602      +8216     
================================================
+ Hits         292046     297540      +5494     
- Misses        89395      92264      +2869     
+ Partials      18945      18798       -147     
Flag Coverage Δ
integration 33.6864% <83.3333%> (?)
unit 73.0669% <100.0000%> (+0.1258%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.9340% <ø> (ø)
br 48.7714% <ø> (-4.3058%) ⬇️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 25, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-25 12:51:00.66201275 +0000 UTC m=+279250.380354952: ☑️ agreed by qw4990.
  • 2023-09-25 13:57:31.501283613 +0000 UTC m=+283241.219625831: ☑️ agreed by time-and-fate.

Copy link

@yudongusa yudongusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the variable part. Please put more details in the issue #45892.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, time-and-fate, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 25, 2023
@winoros
Copy link
Member Author

winoros commented Sep 25, 2023

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 7c1d60b into pingcap:master Sep 25, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants