-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: change SET_VAR behavior for non-verified vars and add some var #47258
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47258 +/- ##
================================================
- Coverage 72.9411% 72.8190% -0.1221%
================================================
Files 1340 1367 +27
Lines 400386 408602 +8216
================================================
+ Hits 292046 297540 +5494
- Misses 89395 92264 +2869
+ Partials 18945 18798 -147
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[LGTM Timeline notifier]Timeline:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the variable part. Please put more details in the issue #45892.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, time-and-fate, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
What problem does this PR solve?
Issue Number: ref #45892
Problem Summary:
What is changed and how it works?
For non-verified vars, we allow SET_VAR to change it.
Throw a warning to notify that the SET_VAR might not take effect since it's not verified.
And some more verified ones.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.